From: Pavel Machek <pavel@ucw.cz>
To: Doug Zobel <dougdev334@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dt: bindings: lp55xx: Add predefined LED pattern
Date: Sun, 16 May 2021 20:22:21 +0200 [thread overview]
Message-ID: <20210516182221.GB3666@localhost> (raw)
In-Reply-To: <20210511204834.2675271-3-dougdev334@gmail.com>
Hi!
> Add a new device tree object for LP5562 predfined led patterns.
typo.
> + "(^pattern@[0-9a-f]$|pattern)":
> + type: object
> + $ref: common.yaml#
> + description: |
> + LP5562 sepcific object. LED pattern program saved to and run
> on LP5562.
typo.
But.. no, not like this.
We have generic pattern trigger. Take a look at its interface. Extend
it
to get parameters from device tree.
Then use existing 'default-trigger' functionality.
Best regards,
Pavel
--
prev parent reply other threads:[~2021-05-16 18:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 20:48 [PATCH 0/2] Device Tree support for LP5562 predefined patterns Doug Zobel
2021-05-11 20:48 ` [PATCH 1/2] leds: lp55xx: support predefined pattern in Device Tree Doug Zobel
2021-05-11 20:48 ` [PATCH 2/2] dt: bindings: lp55xx: Add predefined LED pattern Doug Zobel
2021-05-12 18:35 ` Rob Herring
2021-05-13 2:20 ` Rob Herring
2021-05-13 20:47 ` Doug Zobel
2021-05-16 18:31 ` Pavel Machek
2021-05-17 20:07 ` Doug Zobel
2021-05-16 18:22 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210516182221.GB3666@localhost \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=dougdev334@gmail.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).