From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A28FC48BC2 for ; Wed, 23 Jun 2021 20:11:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7BEA608FE for ; Wed, 23 Jun 2021 20:10:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229755AbhFWUNR (ORCPT ); Wed, 23 Jun 2021 16:13:17 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:35144 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229523AbhFWUNQ (ORCPT ); Wed, 23 Jun 2021 16:13:16 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 130951C0B76; Wed, 23 Jun 2021 22:10:58 +0200 (CEST) Date: Wed, 23 Jun 2021 22:10:57 +0200 From: Pavel Machek To: Doug Zobel Cc: linux-leds@vger.kernel.org Subject: Re: [PATCH] leds: lp55xx: Initialize enable GPIO direction to output Message-ID: <20210623201057.GA8540@amd> References: <20210510204000.GA3714758@odessy> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="VbJkn9YxBvnuCH5J" Content-Disposition: inline In-Reply-To: <20210510204000.GA3714758@odessy> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org --VbJkn9YxBvnuCH5J Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon 2021-05-10 15:40:00, Doug Zobel wrote: > The "Convert to use GPIO descriptors" commit changed the > initialization of the enable GPIO from GPIOF_DIR_OUT to > GPIOD_ASIS. This breaks systems where the GPIO does not > default to output. Changing the enable initialization > to GPIOD_OUT_LOW. Thanks, applied. Pavel --=20 http://www.livejournal.com/~pavelmachek --VbJkn9YxBvnuCH5J Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmDTlVEACgkQMOfwapXb+vJfggCbBDDXJP9+24bNLzwe77Lxp8zu cFkAoMDHBExA2hQfL8OYJ23VhKEFJTed =GJhw -----END PGP SIGNATURE----- --VbJkn9YxBvnuCH5J--