From: Pavel Machek <pavel@ucw.cz>
To: "Michal Vokáč" <michal.vokac@ysoft.com>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
devicetree@vger.kernel.org, Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [RFC 2/2] ARM: dts: imx6dl-yapp4: Fix lp5562 driver probe
Date: Wed, 23 Jun 2021 22:13:48 +0200 [thread overview]
Message-ID: <20210623201347.GC8540@amd> (raw)
In-Reply-To: <1621003477-11250-3-git-send-email-michal.vokac@ysoft.com>
[-- Attachment #1: Type: text/plain, Size: 2158 bytes --]
On Fri 2021-05-14 16:44:37, Michal Vokáč wrote:
> Since the LED multicolor framework support was added in commit
> 92a81562e695 ("leds: lp55xx: Add multicolor framework support to lp55xx")
> LEDs on this platform stopped working.
>
> Author of the framework attempted to accommodate this DT to the
> framework in commit b86d3d21cd4c ("ARM: dts: imx6dl-yapp4: Add reg property
> to the lp5562 channel node") but that is not sufficient. A color property
> is now required even if the multicolor framework is not used, otherwise
> the driver probe fails:
>
> lp5562: probe of 1-0030 failed with error -22
>
> Add the color property to fix this and remove the actually unused white
> channel.
>
> Fixes: b86d3d21cd4c ("ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node")
I believe this is for arm maintainers to take...
> diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
> index 7d2c72562c73..3107bf7fbce5 100644
> --- a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
> +++ b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
> @@ -5,6 +5,7 @@
> #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/input/input.h>
> +#include <dt-bindings/leds/common.h>
> #include <dt-bindings/pwm/pwm.h>
>
> / {
> @@ -271,6 +272,7 @@
> led-cur = /bits/ 8 <0x20>;
> max-cur = /bits/ 8 <0x60>;
> reg = <0>;
> + color = <LED_COLOR_ID_RED>;
> };
>
> chan@1 {
> @@ -278,6 +280,7 @@
> led-cur = /bits/ 8 <0x20>;
> max-cur = /bits/ 8 <0x60>;
> reg = <1>;
> + color = <LED_COLOR_ID_GREEN>;
> };
>
> chan@2 {
> @@ -285,13 +288,7 @@
> led-cur = /bits/ 8 <0x20>;
> max-cur = /bits/ 8 <0x60>;
> reg = <2>;
> - };
> -
> - chan@3 {
> - chan-name = "W";
> - led-cur = /bits/ 8 <0x0>;
> - max-cur = /bits/ 8 <0x0>;
> - reg = <3>;
> + color = <LED_COLOR_ID_BLUE>;
> };
> };
>
What is going on here? "White" channel seems to have disappeared?
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2021-06-23 20:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 14:44 [RFC 0/2] Regression in lp55xx driver since multicolor framework was added? Michal Vokáč
2021-05-14 14:44 ` [RFC 1/2] dt-bindings: leds: Add color as a required property for lp55xx controller Michal Vokáč
2021-05-17 2:27 ` Rob Herring
2021-05-14 14:44 ` [RFC 2/2] ARM: dts: imx6dl-yapp4: Fix lp5562 driver probe Michal Vokáč
2021-06-23 20:13 ` Pavel Machek [this message]
2021-06-24 7:54 ` Michal Vokáč
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210623201347.GC8540@amd \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=jacek.anaszewski@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=michal.vokac@ysoft.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).