From: Pavel Machek <pavel@ucw.cz>
To: Zhen Lei <thunder.leizhen@huawei.com>
Cc: Jan-Simon Moeller <jansimon.moeller@gmx.de>,
linux-leds <linux-leds@vger.kernel.org>
Subject: Re: [PATCH 1/1] leds: blinkm: remove unused variable 'ret' in blinkm_init_hw()
Date: Wed, 23 Jun 2021 22:20:14 +0200 [thread overview]
Message-ID: <20210623202014.GF8540@amd> (raw)
In-Reply-To: <20210519124136.7938-1-thunder.leizhen@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 664 bytes --]
On Wed 2021-05-19 20:41:36, Zhen Lei wrote:
> GCC reports the following warning with W=1:
>
> drivers/leds/leds-blinkm.c:483:6: warning:
> variable 'ret' set but not used [-Wunused-but-set-variable]
> 483 | int ret;
> | ^~~
>
> This variable is not used, remove it to fix the warning.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Sounds like valid warning, and likely function should just propagate
the error value.
It would be good if someone with the hardware could take a look.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2021-06-23 20:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 12:41 [PATCH 1/1] leds: blinkm: remove unused variable 'ret' in blinkm_init_hw() Zhen Lei
2021-06-23 20:20 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210623202014.GF8540@amd \
--to=pavel@ucw.cz \
--cc=jansimon.moeller@gmx.de \
--cc=linux-leds@vger.kernel.org \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).