From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EC6BC4338F for ; Tue, 3 Aug 2021 21:50:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D28A60231 for ; Tue, 3 Aug 2021 21:50:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229745AbhHCVvE (ORCPT ); Tue, 3 Aug 2021 17:51:04 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:40028 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229577AbhHCVvC (ORCPT ); Tue, 3 Aug 2021 17:51:02 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 537381C0B76; Tue, 3 Aug 2021 23:50:50 +0200 (CEST) Date: Tue, 3 Aug 2021 23:50:49 +0200 From: Pavel Machek To: andy@surfacebook.localdomain Cc: Linus Walleij , Andy Shevchenko , Amireddy Mallikarjuna reddy , Abanoub Sameh , Marek =?iso-8859-1?Q?Beh=FAn?= , Krzysztof Kozlowski , Linux LED Subsystem , linux-kernel Subject: Re: [PATCH v2 12/13] leds: rt8515: Put fwnode in any case during ->probe() Message-ID: <20210803215049.GC30387@amd> References: <20210529111935.3849707-1-andy.shevchenko@gmail.com> <20210529111935.3849707-12-andy.shevchenko@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="QRj9sO5tAVLaXnSD" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org --QRj9sO5tAVLaXnSD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat 2021-06-05 12:46:11, andy@surfacebook.localdomain wrote: > Tue, Jun 01, 2021 at 12:06:05PM +0200, Linus Walleij kirjoitti: > > On Sat, May 29, 2021 at 1:19 PM Andy Shevchenko > > wrote: > >=20 > > > fwnode_get_next_available_child_node() bumps a reference counting of > > > a returned variable. We have to balance it whenever we return to > > > the caller. > > > > > > Fixes: e1c6edcbea13 ("leds: rt8515: Add Richtek RT8515 LED driver") > > > Cc: Linus Walleij > > > Signed-off-by: Andy Shevchenko > >=20 > > Reviewed-by: Linus Walleij >=20 > Thanks! >=20 > Pavel, can you, please, review this batch? I think I addressed most of yo= ur > comments if not all. 10-12 applied, thanks. Pavel --=20 http://www.livejournal.com/~pavelmachek --QRj9sO5tAVLaXnSD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmEJujkACgkQMOfwapXb+vJEVQCeID25VeF3Y503w5mOvpeJAY2p R44An0ewAIbhsFtjTGN/eb7UywUywqlY =f9Cw -----END PGP SIGNATURE----- --QRj9sO5tAVLaXnSD--