From: Pavel Machek <pavel@ucw.cz>
To: Vadim Pasternak <vadimp@nvidia.com>
Cc: "linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>
Subject: Re: pending patches
Date: Sun, 12 Sep 2021 09:11:07 +0200 [thread overview]
Message-ID: <20210912071107.GA16081@amd> (raw)
In-Reply-To: <BN9PR12MB53811FD7FC0C8DD410F785CEAFD89@BN9PR12MB5381.namprd12.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1541 bytes --]
Hi!
> > > I have two pending patches:
> > > https://patches.linaro.org/patch/432324/ from 2021-05-07
> >
> > I don't understand this one. Are these normal single-color LEDs, or is it some
> > kind of weird red/orange/amber/green combination exposed as single LED?
>
> This is not single-color LED. LED is controlled by programmable device, color is
> set by writing relevant bit mask combination to the related LED register.
Not a single-color LED yet using single-color API, and now you are
introducing additional hacks on the top of it. Sorry, no.
> > > https://patches.linaro.org/patch/403538/ from 2021-03-16, which has been
> > re-sent.
> >
> > In this case, I don't think i2c bus number is suitable way to identify add-on
> > card. Having some way of identifying add-on cards makes sense (as we'll
> > probably have other vendors having "fault" or "activity"
> > light on their cards), but those boards will not neccessarily have i2c on them.
>
> Line card always has I2C connection, LED color is controlled through a programmable
> device, which is always I2C device. So, this is I2C and bus number identifies topology.
I see it works for your hardware. I don't believe it works for other
vendors having "activity" LED on their card, and I'd like to see
consistent naming across vendors.
> Pavel,
> I have those patches pending very long time. Could you, please, help to get them
> accepted?
Not really, sorry.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2021-09-12 7:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 18:56 pending patches Vadim Pasternak
2021-08-20 8:06 ` Pavel Machek
2021-09-12 5:06 ` Vadim Pasternak
2021-09-12 7:11 ` Pavel Machek [this message]
2021-09-12 8:08 ` Vadim Pasternak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210912071107.GA16081@amd \
--to=pavel@ucw.cz \
--cc=linux-leds@vger.kernel.org \
--cc=vadimp@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).