From: Pavel Machek <pavel@ucw.cz>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
johannes.berg@intel.com, linux-leds@vger.kernel.org
Subject: Re: [PATCH] leds: trigger: Disable CPU trigger on PREEMPT_RT
Date: Wed, 13 Oct 2021 10:08:38 +0200 [thread overview]
Message-ID: <20211013080838.GA10864@amd> (raw)
In-Reply-To: <20210927193424.glrddglskpohbosn@linutronix.de>
[-- Attachment #1: Type: text/plain, Size: 392 bytes --]
Hi!
> - The idle loop (x86 or ARM makes no difference) is always invoked with
> disabled interrupts and so sleeping is a no no on PREEMPT_RT. So a
> spinlock_t can not be acquired in this context.
Ok, I have reviewed code, and your patch seems like a way forward. Can
you resubmit it with fixed changelog?
Thanks,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2021-10-13 8:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 11:15 [PATCH] leds: trigger: Disable CPU trigger on PREEMPT_RT Sebastian Andrzej Siewior
2021-09-27 14:23 ` Pavel Machek
2021-09-27 15:35 ` Thomas Gleixner
2021-09-27 15:44 ` Pavel Machek
2021-09-27 17:18 ` Sebastian Andrzej Siewior
2021-09-27 17:36 ` Johannes Berg
2021-09-27 19:06 ` Pavel Machek
2021-09-27 19:34 ` Sebastian Andrzej Siewior
2021-10-13 8:08 ` Pavel Machek [this message]
2021-10-13 8:39 ` Sebastian Andrzej Siewior
2021-10-13 8:42 ` Pavel Machek
2021-10-13 9:08 ` Sebastian Andrzej Siewior
2021-10-13 9:37 ` [PATCH v2] " Sebastian Andrzej Siewior
2021-10-13 18:08 ` Pavel Machek
2021-09-28 0:14 ` [PATCH] " Thomas Gleixner
2021-09-27 18:48 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211013080838.GA10864@amd \
--to=pavel@ucw.cz \
--cc=bigeasy@linutronix.de \
--cc=johannes.berg@intel.com \
--cc=linux-leds@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox