From: Pavel Machek <pavel@ucw.cz>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: "linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>
Subject: Re: [PATCH] leds: Don't emit brightness set error message if LED supports hw triggers only
Date: Mon, 1 Nov 2021 12:59:10 +0100 [thread overview]
Message-ID: <20211101115910.GA2571@duo.ucw.cz> (raw)
In-Reply-To: <f80b57aa-a542-1d6b-50d9-6de0520f2871@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 635 bytes --]
Hi!
> Working on a driver for specific network LEDs that support HW triggers
> only I got error "Setting an LED's brightness failed" when switching
> to a different trigger. This is caused by call
> led_set_brightness(led_cdev, LED_OFF) in led_trigger_set() because
> both brigthness_set callbacks are not implemented. Let's suppress
> the error message in that case.
Hmm... do we have such LEDs in tree? LED supporting only hardware
triggers is kind of unusual/interesting/and I'm not really sure if we
should have them in LED subsystem.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2021-11-01 11:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 20:25 [PATCH] leds: Don't emit brightness set error message if LED supports hw triggers only Heiner Kallweit
2021-11-01 11:59 ` Pavel Machek [this message]
2021-11-01 12:47 ` Heiner Kallweit
2021-11-01 12:48 ` Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211101115910.GA2571@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=hkallweit1@gmail.com \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).