From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A015C433EF for ; Wed, 15 Dec 2021 20:33:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236077AbhLOUdE (ORCPT ); Wed, 15 Dec 2021 15:33:04 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:46478 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234794AbhLOUdE (ORCPT ); Wed, 15 Dec 2021 15:33:04 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 75A521C0B98; Wed, 15 Dec 2021 21:33:02 +0100 (CET) Date: Wed, 15 Dec 2021 21:32:59 +0100 From: Pavel Machek To: Merlijn Wajer Cc: Ivaylo Dimitrov , Dev Null , Tony Lindgren , Sebastian Reichel , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, linux-omap@vger.kernel.org, Dan Murphy , devicetree@vger.kernel.org, Doug Zobel , Jacek Anaszewski , Linus Walleij , Rob Herring , "Sicelo A . Mhlongo" , =?iso-8859-1?Q?Beno=EEt?= Cousson Subject: Re: [PATCH 0/2] Fix RGB status LED and keyboard backlight LEDs on Nokia N900 Message-ID: <20211215203259.GF28336@duo.ucw.cz> References: <20211212224007.10293-1-merlijn@wizzup.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+ts6NCQ4mrNQIV8p" Content-Disposition: inline In-Reply-To: <20211212224007.10293-1-merlijn@wizzup.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org --+ts6NCQ4mrNQIV8p Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > The RGB status LED and keyboard backlight LEDs were broken on the Nokia N= 900 > since the conversion to gpiod descriptors and additionally later on with = the > addition of multi color support. There was at least one attempt merged to= fix > the lp5523 driver since the gpiod conversion, but it doesn't honour the d= evice > tree, which in the case of the Nokia N900 means that the fix doesn't work. >=20 > In this series are two patches fix the problems: >=20 > * One addresses the gpiod change in the device tree as well as the multi > color support in the device tree; > * The other patch fixes the previous attempt at fixing the driver to hono= ur > the device tree; >=20 > Please let me know if anything seems off, and I'll be glad to make any > recommended changes, thanks! Thank you, I took the series. But if it changes the names in /sys/class/leds, we want to do something else. Best regards, Pavel --=20 http://www.livejournal.com/~pavelmachek --+ts6NCQ4mrNQIV8p Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCYbpQ+wAKCRAw5/Bqldv6 8tAtAKCGwht0aPaKEMlZ4zXs/D60Icv3TQCfRL/bIMI2LAnvY0mTztHvcD5BO6M= =jTvz -----END PGP SIGNATURE----- --+ts6NCQ4mrNQIV8p--