From: Pavel Machek <pavel@denx.de>
To: Uwe Kleine-K??nig <u.kleine-koenig@pengutronix.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel@pengutronix.de, linux-leds@vger.kernel.org
Subject: Re: [PATCH] leds: trigger/tty: Add knob to blink only for tx or only for rx
Date: Wed, 4 May 2022 19:23:54 +0200 [thread overview]
Message-ID: <20220504172354.GD1623@bug> (raw)
In-Reply-To: <20220420162915.2brgxwkrxwqpw5mr@pengutronix.de>
Hi!
> > The newly introduced "triggerevent" attribute allows to restrict
> > blinking to TX or RX only.
>
> I didn't get any maintainer feedback for this patch since nearly 2
> months. I assume the problem is missing maintainer time? Or did this
> fell through the cracks?
Missing time, or more accurately "went on trip with notebook but not charger". Sorry.
But... I don't think sysfs interface is acceptable due to "one value per file" sysfs rule.
Separate "blink for tx" and "blink for rx" files containing booleans should be acceptable.
Best regards,
Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2022-05-04 18:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 15:56 [PATCH] leds: trigger/tty: Add knob to blink only for tx or only for rx Uwe Kleine-König
2022-02-25 9:32 ` Alexander Dahl
2022-02-25 9:46 ` Uwe Kleine-König
2022-04-20 16:29 ` Uwe Kleine-König
2022-05-04 17:23 ` Pavel Machek [this message]
2023-02-23 15:17 ` Alexander Dahl
2023-02-23 20:00 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220504172354.GD1623@bug \
--to=pavel@denx.de \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-leds@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).