From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6850C433EF for ; Wed, 4 May 2022 18:04:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376484AbiEDSIe (ORCPT ); Wed, 4 May 2022 14:08:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376488AbiEDSI0 (ORCPT ); Wed, 4 May 2022 14:08:26 -0400 Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 648B5719FF for ; Wed, 4 May 2022 10:23:57 -0700 (PDT) Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id CB7C11C0BBE; Wed, 4 May 2022 19:23:55 +0200 (CEST) Date: Wed, 4 May 2022 19:23:54 +0200 From: Pavel Machek To: Uwe Kleine-K??nig Cc: Greg Kroah-Hartman , kernel@pengutronix.de, linux-leds@vger.kernel.org Subject: Re: [PATCH] leds: trigger/tty: Add knob to blink only for tx or only for rx Message-ID: <20220504172354.GD1623@bug> References: <20220224155655.702255-1-u.kleine-koenig@pengutronix.de> <20220420162915.2brgxwkrxwqpw5mr@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220420162915.2brgxwkrxwqpw5mr@pengutronix.de> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Hi! > > The newly introduced "triggerevent" attribute allows to restrict > > blinking to TX or RX only. > > I didn't get any maintainer feedback for this patch since nearly 2 > months. I assume the problem is missing maintainer time? Or did this > fell through the cracks? Missing time, or more accurately "went on trip with notebook but not charger". Sorry. But... I don't think sysfs interface is acceptable due to "one value per file" sysfs rule. Separate "blink for tx" and "blink for rx" files containing booleans should be acceptable. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html