From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AE90C4332F for ; Wed, 4 May 2022 18:06:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376382AbiEDSJm (ORCPT ); Wed, 4 May 2022 14:09:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377150AbiEDSJS (ORCPT ); Wed, 4 May 2022 14:09:18 -0400 Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81C6674854; Wed, 4 May 2022 10:25:09 -0700 (PDT) Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 511FE1C0BCC; Wed, 4 May 2022 19:25:08 +0200 (CEST) Date: Wed, 4 May 2022 19:25:07 +0200 From: Pavel Machek To: Aparna M , nm@ti.com, vigneshr@ti.com, kristo@kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, praneeth@ti.com, grygorii.strashko@ti.com, nikhil.nd@ti.com, linux-leds@vger.kernel.org Subject: Re: [PATCH RESEND] arm64: dts: ti: k3-am642-sk: Add DT entry for onboard LEDs Message-ID: <20220504172507.GH1623@bug> References: <20220420072952.3509-1-a-m1@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Hi! > > + led-7 { > > + color = ; > > + function = LED_FUNCTION_INDICATOR; > > + function-enumerator = <8>; > > + linux,default-trigger = "heartbeat"; > > + gpios = <&exp2 7 GPIO_ACTIVE_HIGH>; > > + }; > > This might also be LED_FUNCTION_HEARTBEAT, but it's probably up to > author's personal preferences? You are right that having 8 leds marked as indicator is not too useful. > I added the linux-leds list to Cc. Thank you! Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html