* Re: [PATCH RESEND] arm64: dts: ti: k3-am642-sk: Add DT entry for onboard LEDs
[not found] <20220420072952.3509-1-a-m1@ti.com>
@ 2022-04-25 5:15 ` Alexander Dahl
2022-05-04 17:25 ` Pavel Machek
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Dahl @ 2022-04-25 5:15 UTC (permalink / raw)
To: Aparna M
Cc: nm, vigneshr, kristo, robh+dt, linux-arm-kernel, devicetree,
linux-kernel, praneeth, grygorii.strashko, nikhil.nd, linux-leds
Hello,
Am Wed, Apr 20, 2022 at 12:59:52PM +0530 schrieb Aparna M:
> AM642 SK has 8 leds connected to tpic2810 onboard. Add support for these
> gpio leds.
>
> Signed-off-by: Aparna M <a-m1@ti.com>
> ---
>
> This patch is dependent on:
> https://lore.kernel.org/all/20220223174215.17838-1-a-m1@ti.com/
>
> RESEND patch has been rebased on top of v5.18-rc2.
>
> arch/arm64/boot/dts/ti/k3-am642-sk.dts | 70 ++++++++++++++++++++++++++
> 1 file changed, 70 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am642-sk.dts b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> index 1d7db8bf3a5c..c5979d03c287 100644
> --- a/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> @@ -8,6 +8,7 @@
> #include <dt-bindings/mux/ti-serdes.h>
> #include <dt-bindings/phy/phy.h>
> #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/leds/common.h>
> #include <dt-bindings/net/ti-dp83867.h>
> #include "k3-am642.dtsi"
>
> @@ -125,6 +126,67 @@
> vin-supply = <&vcc_3v3_sys>;
> gpio = <&exp1 3 GPIO_ACTIVE_HIGH>;
> };
> +
> + leds {
According to Documentation/devicetree/bindings/leds/common.yaml this
should read 'led-controller'.
> + compatible = "gpio-leds";
> +
> + led-0 {
> + color = <LED_COLOR_ID_GREEN>;
> + function = LED_FUNCTION_INDICATOR;
> + function-enumerator = <1>;
> + gpios = <&exp2 0 GPIO_ACTIVE_HIGH>;
> + default-state = "off";
> + };
> + led-1 {
> + color = <LED_COLOR_ID_RED>;
> + function = LED_FUNCTION_INDICATOR;
> + function-enumerator = <2>;
> + gpios = <&exp2 1 GPIO_ACTIVE_HIGH>;
> + default-state = "off";
> + };
> + led-2 {
> + color = <LED_COLOR_ID_GREEN>;
> + function = LED_FUNCTION_INDICATOR;
> + function-enumerator = <3>;
> + gpios = <&exp2 2 GPIO_ACTIVE_HIGH>;
> + default-state = "off";
> + };
> + led-3 {
> + color = <LED_COLOR_ID_AMBER>;
> + function = LED_FUNCTION_INDICATOR;
> + function-enumerator = <4>;
> + gpios = <&exp2 3 GPIO_ACTIVE_HIGH>;
> + default-state = "off";
> + };
> + led-4 {
> + color = <LED_COLOR_ID_GREEN>;
> + function = LED_FUNCTION_INDICATOR;
> + function-enumerator = <5>;
> + gpios = <&exp2 4 GPIO_ACTIVE_HIGH>;
> + default-state = "off";
> + };
> + led-5 {
> + color = <LED_COLOR_ID_RED>;
> + function = LED_FUNCTION_INDICATOR;
> + function-enumerator = <6>;
> + gpios = <&exp2 5 GPIO_ACTIVE_HIGH>;
> + default-state = "off";
> + };
> + led-6 {
> + color = <LED_COLOR_ID_GREEN>;
> + function = LED_FUNCTION_INDICATOR;
> + function-enumerator = <7>;
> + gpios = <&exp2 6 GPIO_ACTIVE_HIGH>;
> + default-state = "off";
> + };
> + led-7 {
> + color = <LED_COLOR_ID_AMBER>;
> + function = LED_FUNCTION_INDICATOR;
> + function-enumerator = <8>;
> + linux,default-trigger = "heartbeat";
> + gpios = <&exp2 7 GPIO_ACTIVE_HIGH>;
> + };
This might also be LED_FUNCTION_HEARTBEAT, but it's probably up to
author's personal preferences?
I added the linux-leds list to Cc.
Greets
Alex
> + };
> };
>
> &main_pmx0 {
> @@ -274,6 +336,14 @@
> "VPP_LDO_EN", "RPI_PS_3V3_En",
> "RPI_PS_5V0_En", "RPI_HAT_DETECT";
> };
> +
> + exp2: gpio@60 {
> + compatible = "ti,tpic2810";
> + reg = <0x60>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + gpio-line-names = "LED1","LED2","LED3","LED4","LED5","LED6","LED7","LED8";
> + };
> };
>
> &main_i2c3 {
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread