From: Miaoqian Lin <linmq006@gmail.com>
To: Pavel Machek <pavel@ucw.cz>,
Linus Walleij <linus.walleij@linaro.org>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: linmq006@gmail.com
Subject: [PATCH] leds: netxbig: Fix refcount leak in netxbig_leds_get_of_pdata
Date: Thu, 12 May 2022 09:02:53 +0400 [thread overview]
Message-ID: <20220512050253.8987-1-linmq006@gmail.com> (raw)
of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not needed anymore.
When of_find_device_by_node() fails, of_node_put() is missing.
Fixes: 9af512e81964 ("leds: netxbig: Convert to use GPIO descriptors")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/leds/leds-netxbig.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/leds/leds-netxbig.c b/drivers/leds/leds-netxbig.c
index 77213b79f84d..ceb046500469 100644
--- a/drivers/leds/leds-netxbig.c
+++ b/drivers/leds/leds-netxbig.c
@@ -441,6 +441,7 @@ static int netxbig_leds_get_of_pdata(struct device *dev,
gpio_ext_pdev = of_find_device_by_node(gpio_ext_np);
if (!gpio_ext_pdev) {
dev_err(dev, "Failed to find platform device for gpio-ext\n");
+ of_node_put(gpio_ext_np);
return -ENODEV;
}
gpio_ext_dev = &gpio_ext_pdev->dev;
--
2.25.1
next reply other threads:[~2022-05-12 5:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 5:02 Miaoqian Lin [this message]
2022-05-12 6:53 ` [PATCH] leds: netxbig: Fix refcount leak in netxbig_leds_get_of_pdata Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220512050253.8987-1-linmq006@gmail.com \
--to=linmq006@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).