From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61537C433EF for ; Tue, 24 May 2022 18:34:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237552AbiEXSee (ORCPT ); Tue, 24 May 2022 14:34:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234421AbiEXSed (ORCPT ); Tue, 24 May 2022 14:34:33 -0400 Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE6C76B7F2; Tue, 24 May 2022 11:34:32 -0700 (PDT) Received: by mail-ot1-f43.google.com with SMTP id n2-20020a9d6f02000000b0060b22af84d4so1646915otq.1; Tue, 24 May 2022 11:34:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zjd8D9LIeadEp+4o52T4npY8wF40x2FBi1ttoFUutuI=; b=g10fsUuIGFqsx8TGMY1IH/8gvsxwE1Fj/UBOHqN7y3UF+quPt1Zf6UDdDHjR4xpl4m xy0HyPwxH6Up/uuiTb+qJJTkfirQgLOGE0CSe3S604xEBupMHJ+y+6qq6QGt1gZdXNjv qQq8YV8hWToDFL1SfuGUkKYPDKZUIM8owP0aX4hdwF7pL+OhOXMrOevZoubDcwblkIm/ HTmyzxuDPMASzA2LFV9UDE8r4rpTV0TD340Hhq2lQN3E5JoCf+k+i2Fish+tK+/vIOD5 0WjpflT7V018iLSl9mG0l8at4A5UP0Fd29FmsJHaoizXhlUEu7BC3J9CvNp8hsH5kMft JPLA== X-Gm-Message-State: AOAM5318bBF6BwXUlOgr6Mq4VvsqjWgqAXyCpeg2HoXxu/olWDazFAcy mFrWhGeAsEQiBqvX56bWow== X-Google-Smtp-Source: ABdhPJzWSIvUkNxANyL6S8yGql2pTikwMosJPy7ZGtOM7pUIJp5EfIaENUu1pLQfOdGLrJYjTedpcA== X-Received: by 2002:a05:6830:44a7:b0:606:6bcc:f4c7 with SMTP id r39-20020a05683044a700b006066bccf4c7mr10863879otv.198.1653417272232; Tue, 24 May 2022 11:34:32 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id r125-20020acada83000000b003289f51c2d7sm5614576oig.34.2022.05.24.11.34.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 May 2022 11:34:31 -0700 (PDT) Received: (nullmailer pid 4136645 invoked by uid 1000); Tue, 24 May 2022 18:34:30 -0000 Date: Tue, 24 May 2022 13:34:30 -0500 From: Rob Herring To: Krzysztof Kozlowski Cc: Pavel Machek , Krzysztof Kozlowski , Dan Murphy , Jacek Anaszewski , Sven Schwermer , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Kyle Swenson Subject: Re: [PATCH v2 1/2] dt-bindings: leds: lp50xx: correct reg/unit addresses in example Message-ID: <20220524183430.GA4134907-robh@kernel.org> References: <20220524070815.42997-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220524070815.42997-1-krzysztof.kozlowski@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Tue, May 24, 2022 at 09:08:14AM +0200, Krzysztof Kozlowski wrote: > The multi-led node defined address/size cells, so it intended to have > children with unit addresses. > > The second multi-led's reg property defined three LED indexes within one > reg item, which is not correct - these are three separate items. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v1: > 1. Correct multi-led unit address as well (Rob). > > Cc: Kyle Swenson > --- > .../devicetree/bindings/leds/leds-lp50xx.yaml | 24 ++++++++++++------- > 1 file changed, 15 insertions(+), 9 deletions(-) Reviewed-by: Rob Herring