From: Pavel Machek <pavel@ucw.cz>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Bagas Sanjaya <bagasdotme@gmail.com>,
linux-doc@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: Add leds-qcom-lpg entry to documentation table of contents
Date: Fri, 3 Jun 2022 15:53:26 +0200 [thread overview]
Message-ID: <20220603135326.GA14636@duo.ucw.cz> (raw)
In-Reply-To: <87bkv9x3qu.fsf@meer.lwn.net>
[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]
Hi!
> > After merging linux-leds tree to the mainline [1], htmldocs build produces
> > a new warning:
> >
> > checking consistency... /home/bagas/repo/linux-stable/Documentation/leds/leds-qcom-lpg.rst: WARNING: document isn't included in any toctree
> >
> > The warning above is because leds-qcom-lpg.rst is missing in the table of
> > contents.
> >
> > Add the missing entry.
>
> The fix is good but ...
>
> > [1]: https://lore.kernel.org/all/20220531200619.GA8906@duo.ucw.cz/
> >
> > Fixes: e98a860f65428a ("leds: qcom-lpg: Require pattern to follow documentation")
>
> ...I'm confused as to why you used that commit for a Fixes: tag. It
> touched the file in question but didn't add it in the first place; I
> think 24e2d05d1b68 is the droid you're looking for.
Not sure if that is important, we don't need this in stable, do we?
Anyway
Acked-by: Pavel Machek <pavel@ucw.cz>
... and I assume it goes through your tree?
Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2022-06-03 13:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 2:57 [PATCH] leds: Add leds-qcom-lpg entry to documentation table of contents Bagas Sanjaya
2022-06-03 13:42 ` Jonathan Corbet
2022-06-03 13:53 ` Pavel Machek [this message]
2022-06-04 1:31 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220603135326.GA14636@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=bagasdotme@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).