[PATCH 0/3] leds-bcm63138: post apply/review fixes

[PATCH 0/3] leds-bcm63138: post apply/review fixes

[Rafał Miłecki]

From: Rafał Miłecki <rafal@milecki.pl>

Hi Pavel,

Thanks a lot for accepting my patches. I'm sending those small fixups to
address your comments.

I still have to figure out how to simplify fls() code you pointed out.

Rafał Miłecki (3):
  dt-bindings: leds: leds-bcm63138: unify full stops in descriptions
  leds: add help info about BCM63138 module name
  leds: leds-bcm63138: get rid of LED_OFF

 Documentation/devicetree/bindings/leds/leds-bcm63138.yaml | 2 +-
 drivers/leds/blink/Kconfig                                | 2 ++
 drivers/leds/blink/leds-bcm63138.c                        | 3 +--
 3 files changed, 4 insertions(+), 3 deletions(-)

-- 
2.34.1

[PATCH 1/3] dt-bindings: leds: leds-bcm63138: unify full stops in descriptions

[Rafał Miłecki]

From: Rafał Miłecki <rafal@milecki.pl>

Description of "reg" doesn't have full stop at the end. It makes sense
as it's a one-sentence only. Use the same style for "active-low".

Reported-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 Documentation/devicetree/bindings/leds/leds-bcm63138.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/leds/leds-bcm63138.yaml b/Documentation/devicetree/bindings/leds/leds-bcm63138.yaml
index 99cd4ba9b0ca..52252fb6bb32 100644
--- a/Documentation/devicetree/bindings/leds/leds-bcm63138.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-bcm63138.yaml
@@ -54,7 +54,7 @@ patternProperties:
 
       active-low:
         type: boolean
-        description: Makes LED active low.
+        description: Makes LED active low
 
     required:
       - reg
-- 
2.34.1

[PATCH 2/3] leds: add help info about BCM63138 module name

[Rafał Miłecki]

From: Rafał Miłecki <rafal@milecki.pl>

It's what we do for all other LEDs drivers.

Reported-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 drivers/leds/blink/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig
index c680af01b5a9..945c84286a4e 100644
--- a/drivers/leds/blink/Kconfig
+++ b/drivers/leds/blink/Kconfig
@@ -10,6 +10,8 @@ config LEDS_BCM63138
 	  BCM63138 SoC. The same hardware block is known to be also used
 	  in BCM4908, BCM6848, BCM6858, BCM63148, BCM63381 and BCM68360.
 
+	  If compiled as module it will be called leds-bcm63138.
+
 config LEDS_LGM
        tristate "LED support for LGM SoC series"
        depends on X86 || COMPILE_TEST
-- 
2.34.1

[PATCH 3/3] leds: leds-bcm63138: get rid of LED_OFF

[Rafał Miłecki]

From: Rafał Miłecki <rafal@milecki.pl>

The whole "enum led_brightness" is marked as obsolete. Replace it with a
(non-)zero check.

Reported-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 drivers/leds/blink/leds-bcm63138.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/leds/blink/leds-bcm63138.c b/drivers/leds/blink/leds-bcm63138.c
index c083cb1332cb..2cf2761e4914 100644
--- a/drivers/leds/blink/leds-bcm63138.c
+++ b/drivers/leds/blink/leds-bcm63138.c
@@ -113,8 +113,7 @@ static void bcm63138_leds_enable_led(struct bcm63138_leds *leds,
 {
 	u32 bit = BIT(led->pin);
 
-	bcm63138_leds_update_bits(leds, BCM63138_SW_DATA, bit,
-				  value == LED_OFF ? 0 : bit);
+	bcm63138_leds_update_bits(leds, BCM63138_SW_DATA, bit, value ? bit : 0);
 }
 
 /*
-- 
2.34.1

Re: [PATCH 0/3] leds-bcm63138: post apply/review fixes

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

Hi!

> Hi Pavel,
> 
> Thanks a lot for accepting my patches. I'm sending those small fixups to
> address your comments.

Thank you, applied.

Best regards,
								Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]