From: Rob Herring <robh@kernel.org>
To: Olliver Schinagl <oliver@schinagl.nl>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Olliver Schinagl <oliver+list@schinagl.nl>,
Oleh Kravchenko <oleg@kaa.org.ua>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Pavel Machek <pavel@ucw.cz>, Daniel Mack <daniel@zonque.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org, Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v4] dt-bindings: leds: Expand LED_COLOR_ID definitions
Date: Thu, 8 Sep 2022 13:16:11 -0500 [thread overview]
Message-ID: <20220908181611.GA3001858-robh@kernel.org> (raw)
In-Reply-To: <20220830134613.1564059-1-oliver@schinagl.nl>
On Tue, 30 Aug 2022 15:46:13 +0200, Olliver Schinagl wrote:
> In commit 853a78a7d6c7 (dt-bindings: leds: Add LED_COLOR_ID definitions,
> Sun Jun 9 20:19:04 2019 +0200) the most basic color definitions where
> added. However, there's a little more very common LED colors.
>
> While the documentation states 'add what is missing', engineers tend to
> be lazy and will just use what currently exists. So this patch will take
> (a) list from online retailers [0], [1], [2] and use the common LED colors from
> there, this being reasonable as this is what is currently available to purchase.
>
> Note, that LIME seems to be the modern take to 'Yellow-green' or
> 'Yellowish-green' from some older datasheets.
>
> [0]: https://www.digikey.com/en/products/filter/led-lighting-color/125
> [1]: https://eu.mouser.com/c/optoelectronics/led-lighting/led-emitters/standard-leds-smd
> [2]: https://nl.farnell.com/en-NL/c/optoelectronics-displays/led-products/standard-single-colour-leds-under-75ma
>
> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Changes since v3: Fix typo in purple; Fix whitespacing
> No changes since v2: Re-send with the proper e-mails.
> Changes since v1: Unbreak existing definitions.
> include/dt-bindings/leds/common.h | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
Applied, thanks!
prev parent reply other threads:[~2022-09-08 18:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 13:46 [PATCH v4] dt-bindings: leds: Expand LED_COLOR_ID definitions Olliver Schinagl
2022-08-30 16:57 ` Jacek Anaszewski
2022-08-31 6:15 ` Alexander Dahl
2022-09-08 18:16 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220908181611.GA3001858-robh@kernel.org \
--to=robh@kernel.org \
--cc=daniel@zonque.org \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=oleg@kaa.org.ua \
--cc=oliver+list@schinagl.nl \
--cc=oliver@schinagl.nl \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).