From: Pavel Machek <pavel@ucw.cz>
To: bernardocrodrigues@live.com
Cc: linux-leds@vger.kernel.org
Subject: Re: [PATCH] leds: pca963x: fix blink with hw acceleration
Date: Wed, 21 Sep 2022 12:51:14 +0200 [thread overview]
Message-ID: <20220921105114.GA22654@duo.ucw.cz> (raw)
In-Reply-To: <BY5PR04MB6327FCAC33A75918EA3B65B9A56C9@BY5PR04MB6327.namprd04.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 895 bytes --]
On Sun 2021-12-05 18:00:49, bernardocrodrigues@live.com wrote:
> From: Bernardo Rodrigues <bernardocrodrigues@live.com>
>
> LEDs would behave differently depending on the blink hardware
> acceleration configuration. This commit will make LEDs respond exactly
> the same independently of the hardware acceleration status.
>
> In other words, if you had two pca963x, side by side, one with blink
> hardware acceleration "ON" and the other "OFF; and performed some
> arbitrary sequence of API calls (e.g. turn on/off, change brightness,
> change blink mode, etc.) you probably would end with not matching LED
> states.
>
> 'pca963x software blink' and 'leds-gpio' behavior were used as
> reference.
>
> Actual chip used to validate this change: pca9634
Thanks, applied.
Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
prev parent reply other threads:[~2022-09-21 10:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-05 21:00 [PATCH] leds: pca963x: fix blink with hw acceleration bernardocrodrigues
2022-09-21 10:51 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220921105114.GA22654@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=bernardocrodrigues@live.com \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).