From: Henning Schild <henning.schild@siemens.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
<linux-leds@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: Henning Schild <henning.schild@siemens.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: [PATCH v4] leds: simatic-ipc-leds-gpio: make sure we have the GPIO providing driver
Date: Fri, 7 Oct 2022 17:33:23 +0200 [thread overview]
Message-ID: <20221007153323.1326-1-henning.schild@siemens.com> (raw)
If we register a "leds-gpio" platform device for GPIO pins that do not
exist we get a -EPROBE_DEFER and the probe will be tried again later.
If there is no driver to provide that pin we will poll forever and also
create a lot of log messages.
So check if that GPIO driver is configured, if so it will come up
eventually. If not, we exit our probe function early and do not even
bother registering the "leds-gpio". This method was chosen over "Kconfig
depends" since this way we can add support for more devices and GPIO
backends more easily without "depends":ing on all GPIO backends.
Fixes: a6c80bec3c93 ("leds: simatic-ipc-leds-gpio: Add GPIO version of Siemens driver")
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
drivers/leds/simple/simatic-ipc-leds-gpio.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/leds/simple/simatic-ipc-leds-gpio.c b/drivers/leds/simple/simatic-ipc-leds-gpio.c
index b9eeb8702df0..fb8d427837db 100644
--- a/drivers/leds/simple/simatic-ipc-leds-gpio.c
+++ b/drivers/leds/simple/simatic-ipc-leds-gpio.c
@@ -77,6 +77,8 @@ static int simatic_ipc_leds_gpio_probe(struct platform_device *pdev)
switch (plat->devmode) {
case SIMATIC_IPC_DEVICE_127E:
+ if (!IS_ENABLED(CONFIG_PINCTRL_BROXTON))
+ return -ENODEV;
simatic_ipc_led_gpio_table = &simatic_ipc_led_gpio_table_127e;
break;
case SIMATIC_IPC_DEVICE_227G:
--
2.35.1
next reply other threads:[~2022-10-07 15:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 15:33 Henning Schild [this message]
2022-12-22 10:19 ` [PATCH v4] leds: simatic-ipc-leds-gpio: make sure we have the GPIO providing driver Henning Schild
2022-12-23 11:58 ` Lee Jones
2023-01-02 15:22 ` Henning Schild
2023-01-03 20:20 ` Henning Schild
2023-01-04 14:24 ` Lee Jones
2023-01-04 14:39 ` Henning Schild
2023-01-04 15:51 ` Andy Shevchenko
2023-01-04 19:30 ` Henning Schild
2023-01-05 9:35 ` Andy Shevchenko
2023-01-05 11:23 ` Henning Schild
2023-01-19 21:02 ` Lee Jones
2023-01-23 20:48 ` Henning Schild
2023-01-24 9:46 ` Andy Shevchenko
2023-01-24 10:29 ` Lee Jones
2023-01-24 13:52 ` Henning Schild
2023-01-24 14:50 ` Henning Schild
2023-01-24 13:35 ` Henning Schild
2023-01-24 13:46 ` Andy Shevchenko
2023-01-25 17:36 ` Henning Schild
2023-01-25 17:47 ` Andy Shevchenko
2023-02-02 19:57 ` Henning Schild
2023-02-03 7:59 ` Lee Jones
2023-02-03 16:58 ` Henning Schild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221007153323.1326-1-henning.schild@siemens.com \
--to=henning.schild@siemens.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox