From: "Pali Rohár" <pali@kernel.org>
To: "Marek Behún" <kabel@kernel.org>
Cc: Pavel Machek <pavel@ucw.cz>,
linux-leds@vger.kernel.org,
Josef Schlehofer <josef.schlehofer@nic.cz>
Subject: Re: [PATCH 0/3] leds: turris-omnia: updates
Date: Wed, 2 Nov 2022 01:23:11 +0100 [thread overview]
Message-ID: <20221102002311.twso5wb4tzba5h2k@pali> (raw)
In-Reply-To: <20220704105955.15474-1-kabel@kernel.org>
Ping? Gentle reminder.
On Monday 04 July 2022 12:59:52 Marek Behún wrote:
> Hello Pavel,
>
> the upstream leds-turris-omnia driver is disabled in upstream Omnia
> device-tree and isn't used by TurrisOS because it does not support
> enabling HW control. This is because I wanted to implement it via
> netdev trigger transparent offloading, but I still wasn't able to
> implement this satisfactorily (and truthfully haven't had much time
> to look into this for almost half a year now).
>
> Let's implement this in the meantime via the private trigger
> mechanism that we added two years ago.
>
> In the future if netdev offloading gets implemented, we can still
> keep this implementation if backwards compatibility is desired, or
> we can just drop it.
>
> Marek
>
> Marek Behún (3):
> leds: turris-omnia: support HW controlled mode via private trigger
> leds: turris-omnia: initialize multi-intensity to full
> leds: turris-omnia: change max brightness from 255 to 1
>
> drivers/leds/Kconfig | 1 +
> drivers/leds/leds-turris-omnia.c | 46 +++++++++++++++++++++++++++++++-
> 2 files changed, 46 insertions(+), 1 deletion(-)
>
> --
> 2.35.1
>
next prev parent reply other threads:[~2022-11-02 0:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 10:59 [PATCH 0/3] leds: turris-omnia: updates Marek Behún
2022-07-04 10:59 ` [PATCH 1/3] leds: turris-omnia: support HW controlled mode via private trigger Marek Behún
2022-07-04 10:59 ` [PATCH 2/3] leds: turris-omnia: initialize multi-intensity to full Marek Behún
2022-07-04 10:59 ` [PATCH 3/3] leds: turris-omnia: change max brightness from 255 to 1 Marek Behún
2022-11-02 0:23 ` Pali Rohár [this message]
2023-03-04 7:25 ` [PATCH 0/3] leds: turris-omnia: updates Josef Schlehofer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221102002311.twso5wb4tzba5h2k@pali \
--to=pali@kernel.org \
--cc=josef.schlehofer@nic.cz \
--cc=kabel@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).