Linux LED subsystem development
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Mark Gross <markgross@kernel.org>,
	Andy Shevchenko <andy@kernel.org>, Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Daniel Scally <djrscally@gmail.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	platform-driver-x86@vger.kernel.org, linux-leds@vger.kernel.org,
	linux-gpio@vger.kernel.org, Kate Hsuan <hpa@redhat.com>,
	Mark Pearson <markpearson@lenovo.com>,
	Andy Yeh <andy.yeh@intel.com>, Hao Yao <hao.yao@intel.com>,
	linux-media@vger.kernel.org
Subject: [PATCH v4 01/11] leds: led-class: Add missing put_device() to led_put()
Date: Thu, 19 Jan 2023 14:00:43 +0100	[thread overview]
Message-ID: <20230119130053.111344-2-hdegoede@redhat.com> (raw)
In-Reply-To: <20230119130053.111344-1-hdegoede@redhat.com>

led_put() is used to "undo" a successful of_led_get() call,
of_led_get() uses class_find_device_by_of_node() which returns
a reference to the device which must be free-ed with put_device()
when the caller is done with it.

Add a put_device() call to led_put() to free the reference returned
by class_find_device_by_of_node().

And also add a put_device() in the error-exit case of try_module_get()
failing.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/leds/led-class.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
index 6a8ea94834fa..7391d2cf1370 100644
--- a/drivers/leds/led-class.c
+++ b/drivers/leds/led-class.c
@@ -241,8 +241,10 @@ struct led_classdev *of_led_get(struct device_node *np, int index)
 
 	led_cdev = dev_get_drvdata(led_dev);
 
-	if (!try_module_get(led_cdev->dev->parent->driver->owner))
+	if (!try_module_get(led_cdev->dev->parent->driver->owner)) {
+		put_device(led_cdev->dev);
 		return ERR_PTR(-ENODEV);
+	}
 
 	return led_cdev;
 }
@@ -255,6 +257,7 @@ EXPORT_SYMBOL_GPL(of_led_get);
 void led_put(struct led_classdev *led_cdev)
 {
 	module_put(led_cdev->dev->parent->driver->owner);
+	put_device(led_cdev->dev);
 }
 EXPORT_SYMBOL_GPL(led_put);
 
-- 
2.39.0


  reply	other threads:[~2023-01-19 13:02 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-19 13:00 [PATCH v4 00/11] leds: lookup-table support + int3472/media privacy LED support Hans de Goede
2023-01-19 13:00 ` Hans de Goede [this message]
2023-01-19 13:21   ` [PATCH v4 01/11] leds: led-class: Add missing put_device() to led_put() Andy Shevchenko
2023-01-20  7:23   ` Linus Walleij
2023-01-19 13:00 ` [PATCH v4 02/11] leds: led-class: Add led_module_get() helper Hans de Goede
2023-01-19 13:22   ` Andy Shevchenko
2023-01-20  7:24   ` Linus Walleij
2023-01-19 13:00 ` [PATCH v4 03/11] leds: led-class: Add __devm_led_get() helper Hans de Goede
2023-01-19 13:25   ` Andy Shevchenko
2023-01-20  7:25   ` Linus Walleij
2023-01-19 13:00 ` [PATCH v4 04/11] leds: led-class: Add generic [devm_]led_get() Hans de Goede
2023-01-19 14:04   ` Andy Shevchenko
2023-01-19 14:15     ` Hans de Goede
2023-01-19 14:54       ` Andy Shevchenko
2023-01-19 15:02         ` Hans de Goede
2023-01-20  7:26   ` Linus Walleij
2023-01-20  8:09     ` Lee Jones
2023-01-19 13:00 ` [PATCH v4 05/11] [RFC] leds: led-class: Add devicetree support to led_get() Hans de Goede
2023-01-19 13:29   ` Andy Shevchenko
2023-01-20  7:27   ` Linus Walleij
2023-01-19 13:00 ` [PATCH v4 06/11] media: v4l2-core: Built async and fwnode code into videodev.ko Hans de Goede
2023-01-19 19:47   ` kernel test robot
2023-01-20 10:43     ` Hans de Goede
2023-01-19 20:48   ` kernel test robot
2023-01-19 20:58   ` kernel test robot
2023-01-19 13:00 ` [PATCH v4 07/11] media: v4l2-core: Make the v4l2-core code enable/disable the privacy LED if present Hans de Goede
2023-01-19 13:00 ` [PATCH v4 08/11] platform/x86: int3472/discrete: Refactor GPIO to sensor mapping Hans de Goede
2023-01-19 13:00 ` [PATCH v4 09/11] platform/x86: int3472/discrete: Create a LED class device for the privacy LED Hans de Goede
2023-01-19 13:00 ` [PATCH v4 10/11] platform/x86: int3472/discrete: Move GPIO request to skl_int3472_register_clock() Hans de Goede
2023-01-19 13:00 ` [PATCH v4 11/11] platform/x86: int3472/discrete: Get the polarity from the _DSM entry Hans de Goede
2023-01-20  7:28 ` [PATCH v4 00/11] leds: lookup-table support + int3472/media privacy LED support Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230119130053.111344-2-hdegoede@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=andy.yeh@intel.com \
    --cc=andy@kernel.org \
    --cc=djrscally@gmail.com \
    --cc=hao.yao@intel.com \
    --cc=hpa@redhat.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=lee@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=markgross@kernel.org \
    --cc=markpearson@lenovo.com \
    --cc=mchehab@kernel.org \
    --cc=pavel@ucw.cz \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox