From: kernel test robot <lkp@intel.com>
To: Florian Eckert <fe@dev.tdt.de>,
u.kleine-koenig@pengutronix.de, gregkh@linuxfoundation.org,
jirislaby@kernel.org, pavel@ucw.cz, lee@kernel.org
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org, Eckert.Florian@googlemail.com
Subject: Re: [PATCH v4 2/2] trigger: ledtrig-tty: add additional modes
Date: Tue, 21 Feb 2023 02:22:00 +0800 [thread overview]
Message-ID: <202302210235.GfyfYlvF-lkp@intel.com> (raw)
In-Reply-To: <20230220152038.3877596-3-fe@dev.tdt.de>
Hi Florian,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on tty/tty-testing]
[also build test WARNING on tty/tty-next tty/tty-linus pavel-leds/for-next staging/staging-testing staging/staging-next staging/staging-linus linus/master v6.2 next-20230220]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Florian-Eckert/tty-new-helper-function-tty_get_mget/20230220-232129
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
patch link: https://lore.kernel.org/r/20230220152038.3877596-3-fe%40dev.tdt.de
patch subject: [PATCH v4 2/2] trigger: ledtrig-tty: add additional modes
config: ia64-allyesconfig (https://download.01.org/0day-ci/archive/20230221/202302210235.GfyfYlvF-lkp@intel.com/config)
compiler: ia64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/8da3a8a2edcad2e4b36fce551cac1961a5cd90a6
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Florian-Eckert/tty-new-helper-function-tty_get_mget/20230220-232129
git checkout 8da3a8a2edcad2e4b36fce551cac1961a5cd90a6
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/leds/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202302210235.GfyfYlvF-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/leds/trigger/ledtrig-tty.c:15:24: error: 'TTY_LED_RNG' undeclared here (not in a function); did you mean 'TTY_LED_CNT'?
15 | TTY_LED_LAST = TTY_LED_RNG
| ^~~~~~~~~~~
| TTY_LED_CNT
drivers/leds/trigger/ledtrig-tty.c:33:10: error: array index in initializer not of integer type
33 | [TTY_LED_RNG] = "RNG", // RNG Ring Indicator (RI)
| ^~~~~~~~~~~
drivers/leds/trigger/ledtrig-tty.c:33:10: note: (near initialization for 'mode')
drivers/leds/trigger/ledtrig-tty.c: In function 'ledtrig_tty_mode_show':
drivers/leds/trigger/ledtrig-tty.c:48:34: error: '__TTY_LED_LAST' undeclared (first use in this function); did you mean 'TTY_LED_LAST'?
48 | bool last = i == __TTY_LED_LAST;
| ^~~~~~~~~~~~~~
| TTY_LED_LAST
drivers/leds/trigger/ledtrig-tty.c:48:34: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/leds/trigger/ledtrig-tty.c:50:48: warning: too many arguments for format [-Wformat-extra-args]
50 | len += sysfs_emit_at(buf, len, "%s%s%s",
| ^~~~~~~~
drivers/leds/trigger/ledtrig-tty.c: In function 'tty_led_mode_store':
drivers/leds/trigger/ledtrig-tty.c:81:38: error: '__TTY_LED_MAX' undeclared (first use in this function); did you mean 'TTY_LED_CAR'?
81 | enum tty_led_mode tty_mode = __TTY_LED_MAX;
| ^~~~~~~~~~~~~
| TTY_LED_CAR
drivers/leds/trigger/ledtrig-tty.c:88:26: error: '__TTY_LED_LAST' undeclared (first use in this function); did you mean 'TTY_LED_LAST'?
88 | for (i = 0; i <= __TTY_LED_LAST; i++)
| ^~~~~~~~~~~~~~
| TTY_LED_LAST
>> drivers/leds/trigger/ledtrig-tty.c:89:17: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
89 | if (strncmp(buf, mode[i], size) == 0)
| ^~
drivers/leds/trigger/ledtrig-tty.c:91:25: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
91 | break;
| ^~~~~
drivers/leds/trigger/ledtrig-tty.c:91:25: error: break statement not within loop or switch
>> drivers/leds/trigger/ledtrig-tty.c:81:27: warning: variable 'tty_mode' set but not used [-Wunused-but-set-variable]
81 | enum tty_led_mode tty_mode = __TTY_LED_MAX;
| ^~~~~~~~
drivers/leds/trigger/ledtrig-tty.c:80:17: warning: unused variable 'ret' [-Wunused-variable]
80 | ssize_t ret = size;
| ^~~
drivers/leds/trigger/ledtrig-tty.c:79:34: warning: unused variable 'trigger_data' [-Wunused-variable]
79 | struct ledtrig_tty_data *trigger_data = led_trigger_get_drvdata(dev);
| ^~~~~~~~~~~~
drivers/leds/trigger/ledtrig-tty.c:92:17: error: no return statement in function returning non-void [-Werror=return-type]
92 | }
| ^
drivers/leds/trigger/ledtrig-tty.c: At top level:
drivers/leds/trigger/ledtrig-tty.c:94:9: error: expected identifier or '(' before 'if'
94 | if (tty_mode > __TTY_LED_LAST)
| ^~
drivers/leds/trigger/ledtrig-tty.c:97:20: error: expected declaration specifiers or '...' before '&' token
97 | mutex_lock(&trigger_data->mutex);
| ^
drivers/leds/trigger/ledtrig-tty.c:98:21: error: expected '=', ',', ';', 'asm' or '__attribute__' before '->' token
98 | trigger_data->mode = tty_mode;
| ^~
drivers/leds/trigger/ledtrig-tty.c:99:22: error: expected declaration specifiers or '...' before '&' token
99 | mutex_unlock(&trigger_data->mutex);
| ^
drivers/leds/trigger/ledtrig-tty.c:101:9: error: expected identifier or '(' before 'return'
101 | return ret;
| ^~~~~~
drivers/leds/trigger/ledtrig-tty.c:102:1: error: expected identifier or '(' before '}' token
102 | }
| ^
cc1: some warnings being treated as errors
vim +50 drivers/leds/trigger/ledtrig-tty.c
40
41 static ssize_t ledtrig_tty_mode_show(char *buf, enum tty_led_mode tty_mode)
42 {
43 int len = 0;
44 int i;
45
46 for (i = 0; i <= TTY_LED_LAST; i++) {
47 bool hit = tty_mode == i;
48 bool last = i == __TTY_LED_LAST;
49
> 50 len += sysfs_emit_at(buf, len, "%s%s%s",
51 hit ? "[" : "",
52 mode[i],
53 hit ? "]" : "",
54 last ? "" : " ");
55 }
56
57 len += sysfs_emit_at(buf, len, "\n");
58
59 return len;
60 }
61
62 static ssize_t tty_led_mode_show(struct device *dev,
63 struct device_attribute *attr, char *buf)
64 {
65 struct ledtrig_tty_data *trigger_data = led_trigger_get_drvdata(dev);
66 enum tty_led_mode tty_mode;
67
68 mutex_lock(&trigger_data->mutex);
69 tty_mode = trigger_data->mode;
70 mutex_unlock(&trigger_data->mutex);
71
72 return ledtrig_tty_mode_show(buf, tty_mode);
73 }
74
75 static ssize_t tty_led_mode_store(struct device *dev,
76 struct device_attribute *attr, const char *buf,
77 size_t size)
78 {
79 struct ledtrig_tty_data *trigger_data = led_trigger_get_drvdata(dev);
80 ssize_t ret = size;
> 81 enum tty_led_mode tty_mode = __TTY_LED_MAX;
82 int i;
83
84 /* Check for new line in string*/
85 if (size > 0 && buf[size - 1] == '\n')
86 size -= 1;
87
88 for (i = 0; i <= __TTY_LED_LAST; i++)
> 89 if (strncmp(buf, mode[i], size) == 0)
90 tty_mode = i;
91 break;
92 }
93
94 if (tty_mode > __TTY_LED_LAST)
95 return -EINVAL;
96
97 mutex_lock(&trigger_data->mutex);
98 trigger_data->mode = tty_mode;
99 mutex_unlock(&trigger_data->mutex);
100
101 return ret;
102 }
103 static DEVICE_ATTR_RW(tty_led_mode);
104
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next prev parent reply other threads:[~2023-02-20 18:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 15:20 [PATCH v4 0/2] leds: ledtrig-tty: add tty_led_mode xtension Florian Eckert
2023-02-20 15:20 ` [PATCH v4 1/2] tty: new helper function tty_get_mget Florian Eckert
2023-02-20 15:20 ` [PATCH v4 2/2] trigger: ledtrig-tty: add additional modes Florian Eckert
2023-02-20 18:22 ` kernel test robot [this message]
2023-02-20 22:27 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202302210235.GfyfYlvF-lkp@intel.com \
--to=lkp@intel.com \
--cc=Eckert.Florian@googlemail.com \
--cc=fe@dev.tdt.de \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pavel@ucw.cz \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox