From: Daniel Scally <dan.scally@ideasonboard.com>
To: linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org
Cc: pavel@ucw.cz, lee@kernel.org, hdegoede@redhat.com,
markgross@kernel.org, sboyd@kernel.org, hpa@redhat.com,
Daniel Scally <dan.scally@ideasonboard.com>
Subject: [PATCH 2/8] platform/x86: int3472: Init LED registers using platform data
Date: Wed, 22 Mar 2023 16:09:20 +0000 [thread overview]
Message-ID: <20230322160926.948687-3-dan.scally@ideasonboard.com> (raw)
In-Reply-To: <20230322160926.948687-1-dan.scally@ideasonboard.com>
Check platform data to discover the appropriate settings for the PMIC's
WLED registers and set them during probe.
Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com>
---
drivers/leds/leds-tps68470.c | 51 ++++++++++++++++++++++++++++++++++++
1 file changed, 51 insertions(+)
diff --git a/drivers/leds/leds-tps68470.c b/drivers/leds/leds-tps68470.c
index 35aeb5db89c8..d2060fe4259d 100644
--- a/drivers/leds/leds-tps68470.c
+++ b/drivers/leds/leds-tps68470.c
@@ -11,6 +11,7 @@
#include <linux/leds.h>
#include <linux/mfd/tps68470.h>
#include <linux/module.h>
+#include <linux/platform_data/tps68470.h>
#include <linux/platform_device.h>
#include <linux/property.h>
#include <linux/regmap.h>
@@ -113,6 +114,52 @@ static int tps68470_ledb_current_init(struct platform_device *pdev,
return ret;
}
+static int tps68470_leds_init(struct tps68470_device *tps68470)
+{
+ struct tps68470_led_platform_data *pdata = tps68470->dev->platform_data;
+ int ret;
+
+ if (!pdata)
+ return 0;
+
+ ret = regmap_write(tps68470->regmap, TPS68470_REG_ILEDCTL, pdata->iledctl_ctrlb);
+ if (ret)
+ return dev_err_probe(tps68470->dev, ret, "failed to set ILED CTRLB\n");
+
+ ret = regmap_write(tps68470->regmap, TPS68470_REG_WLEDMAXF,
+ pdata->wledmaxf & TPS68470_WLEDMAXF_MAX_CUR_MASK);
+ if (ret)
+ return dev_err_probe(tps68470->dev, ret, "failed to set WLEDMAXF\n");
+
+ ret = regmap_write(tps68470->regmap, TPS68470_REG_WLEDTO, pdata->wledto);
+ if (ret)
+ return dev_err_probe(tps68470->dev, ret, "failed to set WLEDTO\n");
+
+ ret = regmap_write(tps68470->regmap, TPS68470_REG_WLEDC1,
+ pdata->wledc1 & TPS68470_WLEDC_ILED_MASK);
+ if (ret)
+ return dev_err_probe(tps68470->dev, ret, "failed to set WLEDC1\n");
+
+ ret = regmap_write(tps68470->regmap, TPS68470_REG_WLEDC2,
+ pdata->wledc2 & TPS68470_WLEDC_ILED_MASK);
+ if (ret)
+ return dev_err_probe(tps68470->dev, ret, "failed to set WLEDC2\n");
+
+ ret = regmap_update_bits(tps68470->regmap, TPS68470_REG_WLEDCTL,
+ TPS68470_WLED_DISLED1,
+ pdata->wledctl_disled1 ? TPS68470_WLED_DISLED1 : 0);
+ if (ret)
+ return dev_err_probe(tps68470->dev, ret, "failed to set DISLED1\n");
+
+ ret = regmap_update_bits(tps68470->regmap, TPS68470_REG_WLEDCTL,
+ TPS68470_WLED_DISLED2,
+ pdata->wledctl_disled2 ? TPS68470_WLED_DISLED2 : 0);
+ if (ret)
+ dev_err_probe(tps68470->dev, ret, "failed to set DISLED2\n");
+
+ return 0;
+}
+
static int tps68470_leds_probe(struct platform_device *pdev)
{
int i = 0;
@@ -160,6 +207,10 @@ static int tps68470_leds_probe(struct platform_device *pdev)
}
}
+ ret = tps68470_leds_init(tps68470);
+ if (ret)
+ goto err_exit;
+
err_exit:
if (ret) {
for (i = 0; i < TPS68470_NUM_LEDS; i++) {
--
2.34.1
next prev parent reply other threads:[~2023-03-22 16:10 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 16:09 [PATCH 0/8] Add WLED support to TPS68470 LED driver Daniel Scally
2023-03-22 16:09 ` [PATCH 1/8] platform/x86: int3472: Add platform data for LEDs Daniel Scally
2023-03-22 17:14 ` Hans de Goede
2023-03-22 16:09 ` Daniel Scally [this message]
2023-03-22 17:16 ` [PATCH 2/8] platform/x86: int3472: Init LED registers using platform data Hans de Goede
2023-03-22 16:09 ` [PATCH 3/8] platform/x86: int3472: Add TPS68470 LED Board Data Daniel Scally
2023-03-22 17:17 ` Hans de Goede
2023-03-22 16:09 ` [PATCH 4/8] platform/x86: int3472: Add tps68470-led as clock consumer Daniel Scally
2023-03-22 17:19 ` Hans de Goede
2023-03-22 16:09 ` [PATCH 5/8] leds: tps68470: Refactor tps68470_brightness_get() Daniel Scally
2023-03-22 17:22 ` Hans de Goede
2023-03-23 7:43 ` Dan Scally
2023-03-23 9:52 ` Hans de Goede
2023-03-23 9:53 ` Dan Scally
2023-03-22 16:09 ` [PATCH 6/8] leds: tps68470: Support the WLED driver Daniel Scally
2023-03-22 17:24 ` Hans de Goede
2023-03-23 11:22 ` Pavel Machek
2023-03-23 16:25 ` Dan Scally
2023-03-27 13:23 ` Hans de Goede
2023-03-22 16:09 ` [PATCH 7/8] platform/x86: int3472: Support LED lookups in board data Daniel Scally
2023-03-22 17:25 ` Hans de Goede
2023-03-22 16:09 ` [PATCH 8/8] platform/x86: int3472: Define LED lookup data for MS Surface Go Daniel Scally
2023-03-22 17:34 ` Hans de Goede
2023-03-23 10:31 ` Dan Scally
2023-03-23 11:15 ` Hans de Goede
2023-03-22 17:40 ` [PATCH 0/8] Add WLED support to TPS68470 LED driver Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230322160926.948687-3-dan.scally@ideasonboard.com \
--to=dan.scally@ideasonboard.com \
--cc=hdegoede@redhat.com \
--cc=hpa@redhat.com \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox