From: Lee Jones <lee@kernel.org>
To: Dan Carpenter <error27@gmail.com>
Cc: Fenglin Wu <quic_fenglinw@quicinc.com>,
linux-leds@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] leds: flash: qcom: Fix a signedness bug in qcom_flash_register_led_device()
Date: Thu, 30 Mar 2023 13:46:28 +0100 [thread overview]
Message-ID: <20230330124628.GL434339@google.com> (raw)
In-Reply-To: <20aeda89-7ed2-4dd8-b707-404a15289fbc@kili.mountain>
On Wed, 22 Mar 2023, Dan Carpenter wrote:
> This bug is basically harmless at runtime because of the surrounding lines.
> Still the fwnode_property_count_u32() function returns negative error codes
> so storing them in an unsigned int will not work.
>
> Fixes: 96a2e242a5dc ("leds: flash: Add driver to support flash LED module in QCOM PMICs")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> The patch prefix on this was slightly tricky. Ideally when people add a
> new driver the patch which adds the driver would use the patch prefix
> for the driver instead of the subsystem:
>
> Not ideal: [PATCH] leds: Add new driver for QWERTY
> Ideal: [PATCH] leds: qwerty: Add new driver
That tends not to happen in my experience and I'm fine with it.
This precedence is usually set by the second commit.
> drivers/leds/flash/leds-qcom-flash.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied, thanks
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2023-03-30 12:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 9:05 [PATCH] leds: flash: qcom: Fix a signedness bug in qcom_flash_register_led_device() Dan Carpenter
2023-03-23 11:50 ` Pavel Machek
2023-03-30 12:46 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230330124628.GL434339@google.com \
--to=lee@kernel.org \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=quic_fenglinw@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox