From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68FD1C77B6E for ; Fri, 14 Apr 2023 15:56:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230088AbjDNP4g (ORCPT ); Fri, 14 Apr 2023 11:56:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229721AbjDNP4g (ORCPT ); Fri, 14 Apr 2023 11:56:36 -0400 Received: from mail.andi.de1.cc (mail.andi.de1.cc [IPv6:2a01:238:4321:8900:456f:ecd6:43e:202c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 345AAE6B; Fri, 14 Apr 2023 08:56:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20220719; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=IxIiLwxZ4JELikkl8mE8hAPiE2Ow7m9ULqfCegsIKd0=; b=oSJ93MLD9OM/TljOO8ql3kvpDP dYUKrZSVH+QhVaS814B21VZV5S+m6ZjCwtjalHaLXzQZwIaMI0F+9BlRPDs1IBDieqWrtEJvShu3b IY7+4uepDQHkC6YCjbHPJjt7ItNzU+TCtPgbniVeNu5a45iixc5B7RYJHmPV3Uax1j9gTslw9Pld9 wmO6X86AbqAIBIgoytudYOPLWUCKNVScGMwmr0pP2Cjig3MLNRGK9s9tQHPPvgKo4gDlWYtTVxRn/ 2A2oKuJOxFCOb/cJpT8+fnb4HczUTC/iKluXny8KVg2gx0OQHDP6WOGL+DIY0IpiO4pi9JjHmZtrq kBiEpSYQ==; Received: from p200300ccff0c0d001a3da2fffebfd33a.dip0.t-ipconnect.de ([2003:cc:ff0c:d00:1a3d:a2ff:febf:d33a] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1pnLmp-0006Rb-7S; Fri, 14 Apr 2023 17:56:31 +0200 Date: Fri, 14 Apr 2023 17:56:29 +0200 From: Andreas Kemnade To: Krzysztof Kozlowski Cc: pavel@ucw.cz, lee@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Matti Vaittinen Subject: Re: [PATCH v4 1/2] dt-bindings: leds: Add ROHM BD2606MVV LED driver Message-ID: <20230414175629.2f03e503@aktux> In-Reply-To: <20230414175412.37a15572@aktux> References: <20230414055341.335456-1-andreas@kemnade.info> <20230414055341.335456-2-andreas@kemnade.info> <20230414175412.37a15572@aktux> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.24; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Fri, 14 Apr 2023 17:54:12 +0200 Andreas Kemnade wrote: > On Fri, 14 Apr 2023 17:28:49 +0200 > Krzysztof Kozlowski wrote: > > > On 14/04/2023 07:53, Andreas Kemnade wrote: > > > Document ROHM BD2606MVV LED driver devicetree bindings. > > > > Subject: no improvements and no comments from your side. Why? > > > old subject (v2): > > dt-bindings: leds: ROHM BD2606MVV LED driver > > Your comment: > Subject: maybe drop "driver" (suggests it is for Linux drivers, although > maybe it matches the actual hardware here?) and add missing verb, e.g. > "Add ROHM ..." > > New Subject (v3/4): > dt-bindings: leds: Add ROHM BD2606MVV LED driver > > What is still missing? > ok, answering myself: missing verb was added ("Add") but s/driver// is missing Sorry. Regards, Andreas