From: Lee Jones <lee@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Maarten Zanders <maarten.zanders@mind.be>,
Pavel Machek <pavel@ucw.cz>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v7 1/2] dt-bindings: leds-lp55xx: add ti,charge-pump-mode
Date: Thu, 20 Apr 2023 11:27:03 +0100 [thread overview]
Message-ID: <20230420102703.GH9904@google.com> (raw)
In-Reply-To: <20230411132204.GA2918042-robh@kernel.org>
On Tue, 11 Apr 2023, Rob Herring wrote:
> On Fri, Apr 07, 2023 at 12:23:23PM +0200, Maarten Zanders wrote:
> > Add a binding to configure the internal charge pump for lp55xx.
> >
> > Signed-off-by: Maarten Zanders <maarten.zanders@mind.be>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> >
> > Notes:
> > v1: implement as bool to disable charge pump
> > v2: rewrite to use string configuration, supporting all modes
> > v3: simplification by replacing string option by u8 constant,
> > removing previous Reviewed-by tags as it's a complete
> > rewrite of the patch.
> > v4: added notes
> > v5: dual license, change property type to u32
> > v6: change license type for leds-lp-55xx.h to preferred tag
> >
> > .../devicetree/bindings/leds/leds-lp55xx.yaml | 8 ++++++++
> > include/dt-bindings/leds/leds-lp55xx.h | 10 ++++++++++
> > 2 files changed, 18 insertions(+)
> > create mode 100644 include/dt-bindings/leds/leds-lp55xx.h
> >
> > diff --git a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml
> > index ae607911f1db..ede9cb9ca175 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml
> > +++ b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml
> > @@ -66,6 +66,12 @@ properties:
> > '#size-cells':
> > const: 0
> >
> > + ti,charge-pump-mode:
> > + description:
> > + Set the operating mode of the internal charge pump as defined in
> > + <dt-bindings/leds/leds-lp55xx.h>. Defaults to auto.
> > + $ref: /schemas/types.yaml#/definitions/uint32
>
> Needs constraints:
>
> default: 3 # Auto
> maximum: 3
Once this has been fixed, I'll apply both.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-04-20 10:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 10:23 [PATCH v7 0/2] leds: lp55xx: configure internal charge pump Maarten Zanders
2023-04-07 10:23 ` [PATCH v7 1/2] dt-bindings: leds-lp55xx: add ti,charge-pump-mode Maarten Zanders
2023-04-11 13:22 ` Rob Herring
2023-04-20 10:27 ` Lee Jones [this message]
2023-04-07 10:23 ` [PATCH v7 2/2] leds: lp55xx: configure internal charge pump Maarten Zanders
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230420102703.GH9904@google.com \
--to=lee@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=maarten.zanders@mind.be \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).