From: Lee Jones <lee@kernel.org>
To: Wadim Egorov <w.egorov@phytec.de>
Cc: upstream@lists.phytec.de, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-leds@vger.kernel.org,
riku.voipio@iki.fi, krzysztof.kozlowski+dt@linaro.org,
robh+dt@kernel.org, pavel@ucw.cz
Subject: Re: [PATCH v3] dt-bindings: leds: Convert PCA9532 to dtschema
Date: Thu, 20 Apr 2023 12:28:23 +0100 [thread overview]
Message-ID: <20230420112823.GB970483@google.com> (raw)
In-Reply-To: <20230412140552.451527-1-w.egorov@phytec.de>
On Wed, 12 Apr 2023, Wadim Egorov wrote:
> Convert the PCA9532 LED Dimmer to dtschema.
> While at it, update the example to match recommended node names and
> the link to the product datasheet. Also add GPIO properties since
> the driver allows to use unused pins as GPIOs.
>
> Signed-off-by: Wadim Egorov <w.egorov@phytec.de>
> ---
> v3:
> - Add gpio-controller & gpio-cells property, fixes
> arch/arm/boot/dts/lpc3250-ea3250.dtb: pca9532@60: '#gpio-cells', 'gpio-controller'
> do not match any of the regexes: '^led-[0-9a-z]+$', 'pinctrl-[0-9]+'
>
> v2:
> - Rename yaml file to match compatibles, nxp,pca953x.yaml
> - Remove Jacek Anaszewski from maintainers list
> - Remove color labels in example
> - Restore labels/default-states from original example
> - Drop reg description
> - Add unevaluatedProperties to patternProperties scope
> - Update description of type property & set default to 0
> - Fix indentation in example
> ---
> .../devicetree/bindings/leds/leds-pca9532.txt | 49 ----------
> .../devicetree/bindings/leds/nxp,pca953x.yaml | 90 +++++++++++++++++++
> 2 files changed, 90 insertions(+), 49 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/leds/leds-pca9532.txt
> create mode 100644 Documentation/devicetree/bindings/leds/nxp,pca953x.yaml
Applied, thanks
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2023-04-20 11:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 14:05 [PATCH v3] dt-bindings: leds: Convert PCA9532 to dtschema Wadim Egorov
2023-04-12 14:05 ` Wadim Egorov
2023-04-13 16:46 ` Krzysztof Kozlowski
2023-04-14 12:20 ` Pavel Machek
2023-04-20 11:28 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230420112823.GB970483@google.com \
--to=lee@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=riku.voipio@iki.fi \
--cc=robh+dt@kernel.org \
--cc=upstream@lists.phytec.de \
--cc=w.egorov@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).