From: Lee Jones <lee@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Pavel Machek <pavel@ucw.cz>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Yauhen Kharuzhy <jekhor@gmail.com>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v3 2/5] leds: cht-wcove: Add suspend/resume handling
Date: Mon, 15 May 2023 16:06:40 +0100 [thread overview]
Message-ID: <20230515150640.GI10825@google.com> (raw)
In-Reply-To: <20230430195952.862527-3-hdegoede@redhat.com>
On Sun, 30 Apr 2023, Hans de Goede wrote:
> When LED1 is showing the tablet is charging and then the device gets
> suspended followed by unplugging the charger, then it will incorrectly
> still show it is charging.
>
> To avoid this turn both LEDs off on suspend, just like the PMIC always
> turns them off when the tablet is powered off (even if the tablet is
> charging). If hw-control is supported for LED1, then restore the
> initial hw-control settings to let the hw control LED1 while suspended.
>
> To restore the state the LEDs had before suspending, save it before
> turning the LEDs off and restore it on resume.
>
> Acked-by: Pavel Machek <pavel@ucw.cz>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/leds/leds-cht-wcove.c | 33 +++++++++++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
Applied, thanks
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-05-15 15:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-30 19:59 [PATCH v3 0/5] leds: Add Intel Cherry Trail Whiskey Cove PMIC LED driver Hans de Goede
2023-04-30 19:59 ` [PATCH v3 1/5] " Hans de Goede
2023-05-15 15:06 ` Lee Jones
2023-04-30 19:59 ` [PATCH v3 2/5] leds: cht-wcove: Add suspend/resume handling Hans de Goede
2023-05-15 15:06 ` Lee Jones [this message]
2023-04-30 19:59 ` [PATCH v3 3/5] leds: cht-wcove: Add support for breathing mode use hw_pattern sysfs API Hans de Goede
2023-05-15 15:07 ` Lee Jones
2023-04-30 19:59 ` [PATCH v3 4/5] leds: cht-wcove: Set default trigger for charging LED Hans de Goede
2023-05-15 15:07 ` Lee Jones
2023-04-30 19:59 ` [PATCH v3 5/5] leds: cht-wcove: Use breathing when LED_INIT_DEFAULT_TRIGGER is set Hans de Goede
2023-05-15 15:07 ` Lee Jones
2023-05-04 8:05 ` [PATCH v3 0/5] leds: Add Intel Cherry Trail Whiskey Cove PMIC LED driver Yauhen Kharuzhy
2023-05-04 8:56 ` Hans de Goede
2023-05-04 11:29 ` Yauhen Kharuzhy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230515150640.GI10825@google.com \
--to=lee@kernel.org \
--cc=hdegoede@redhat.com \
--cc=jacek.anaszewski@gmail.com \
--cc=jekhor@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).