From: Lee Jones <lee@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Pavel Machek <pavel@ucw.cz>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Yauhen Kharuzhy <jekhor@gmail.com>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v3 5/5] leds: cht-wcove: Use breathing when LED_INIT_DEFAULT_TRIGGER is set
Date: Mon, 15 May 2023 16:07:44 +0100 [thread overview]
Message-ID: <20230515150744.GL10825@google.com> (raw)
In-Reply-To: <20230430195952.862527-6-hdegoede@redhat.com>
On Sun, 30 Apr 2023, Hans de Goede wrote:
> The desired default behavior of LED1 / the charge LED is breathing
> while charging and on/solid when full. Since triggers cannot select
> breathing, blink_set() gets called when charging. Use breathing
> when the default "charging-blink-full-solid" trigger is used to
> achieve the desired default behavior.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> Changes in v3:
> - Also set on/off delay to 1000 so that we get a slow breathing effect,
> this counter-acts the v2 cht_wc_leds_set_effect() change changing
> the default delays from 1000 to 500
> ---
> drivers/leds/leds-cht-wcove.c | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
Applied, thanks
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-05-15 15:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-30 19:59 [PATCH v3 0/5] leds: Add Intel Cherry Trail Whiskey Cove PMIC LED driver Hans de Goede
2023-04-30 19:59 ` [PATCH v3 1/5] " Hans de Goede
2023-05-15 15:06 ` Lee Jones
2023-04-30 19:59 ` [PATCH v3 2/5] leds: cht-wcove: Add suspend/resume handling Hans de Goede
2023-05-15 15:06 ` Lee Jones
2023-04-30 19:59 ` [PATCH v3 3/5] leds: cht-wcove: Add support for breathing mode use hw_pattern sysfs API Hans de Goede
2023-05-15 15:07 ` Lee Jones
2023-04-30 19:59 ` [PATCH v3 4/5] leds: cht-wcove: Set default trigger for charging LED Hans de Goede
2023-05-15 15:07 ` Lee Jones
2023-04-30 19:59 ` [PATCH v3 5/5] leds: cht-wcove: Use breathing when LED_INIT_DEFAULT_TRIGGER is set Hans de Goede
2023-05-15 15:07 ` Lee Jones [this message]
2023-05-04 8:05 ` [PATCH v3 0/5] leds: Add Intel Cherry Trail Whiskey Cove PMIC LED driver Yauhen Kharuzhy
2023-05-04 8:56 ` Hans de Goede
2023-05-04 11:29 ` Yauhen Kharuzhy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230515150744.GL10825@google.com \
--to=lee@kernel.org \
--cc=hdegoede@redhat.com \
--cc=jacek.anaszewski@gmail.com \
--cc=jekhor@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).