* [PATCH] leds: blinkm: Replace all non-returning strlcpy with strscpy
@ 2023-05-23 2:12 Azeem Shaikh
2023-05-23 17:19 ` Kees Cook
2023-05-25 11:31 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Azeem Shaikh @ 2023-05-23 2:12 UTC (permalink / raw)
To: Jan-Simon Moeller
Cc: linux-hardening, Azeem Shaikh, linux-kernel, Pavel Machek,
Lee Jones, linux-leds
strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89
Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
---
drivers/leds/leds-blinkm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/leds-blinkm.c b/drivers/leds/leds-blinkm.c
index 37f2f32ae42d..8c2ae0798cfc 100644
--- a/drivers/leds/leds-blinkm.c
+++ b/drivers/leds/leds-blinkm.c
@@ -561,7 +561,7 @@ static int blinkm_detect(struct i2c_client *client, struct i2c_board_info *info)
return -ENODEV;
}
- strlcpy(info->type, "blinkm", I2C_NAME_SIZE);
+ strscpy(info->type, "blinkm", I2C_NAME_SIZE);
return 0;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] leds: blinkm: Replace all non-returning strlcpy with strscpy
2023-05-23 2:12 [PATCH] leds: blinkm: Replace all non-returning strlcpy with strscpy Azeem Shaikh
@ 2023-05-23 17:19 ` Kees Cook
2023-05-25 11:31 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Kees Cook @ 2023-05-23 17:19 UTC (permalink / raw)
To: Azeem Shaikh
Cc: Jan-Simon Moeller, linux-hardening, linux-kernel, Pavel Machek,
Lee Jones, linux-leds
On Tue, May 23, 2023 at 02:12:28AM +0000, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> [2] https://github.com/KSPP/linux/issues/89
>
> Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] leds: blinkm: Replace all non-returning strlcpy with strscpy
2023-05-23 2:12 [PATCH] leds: blinkm: Replace all non-returning strlcpy with strscpy Azeem Shaikh
2023-05-23 17:19 ` Kees Cook
@ 2023-05-25 11:31 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2023-05-25 11:31 UTC (permalink / raw)
To: Azeem Shaikh
Cc: Jan-Simon Moeller, linux-hardening, linux-kernel, Pavel Machek,
linux-leds
On Tue, 23 May 2023, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> [2] https://github.com/KSPP/linux/issues/89
>
> Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
> ---
> drivers/leds/leds-blinkm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-25 11:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-23 2:12 [PATCH] leds: blinkm: Replace all non-returning strlcpy with strscpy Azeem Shaikh
2023-05-23 17:19 ` Kees Cook
2023-05-25 11:31 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).