From: Lee Jones <lee@kernel.org>
To: Azeem Shaikh <azeemshaikh38@gmail.com>
Cc: Jan-Simon Moeller <jansimon.moeller@gmx.de>,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
Pavel Machek <pavel@ucw.cz>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH] leds: blinkm: Replace all non-returning strlcpy with strscpy
Date: Thu, 25 May 2023 12:31:27 +0100 [thread overview]
Message-ID: <20230525113127.GD423913@google.com> (raw)
In-Reply-To: <20230523021228.2406112-1-azeemshaikh38@gmail.com>
On Tue, 23 May 2023, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> [2] https://github.com/KSPP/linux/issues/89
>
> Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
> ---
> drivers/leds/leds-blinkm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2023-05-25 11:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 2:12 [PATCH] leds: blinkm: Replace all non-returning strlcpy with strscpy Azeem Shaikh
2023-05-23 17:19 ` Kees Cook
2023-05-25 11:31 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230525113127.GD423913@google.com \
--to=lee@kernel.org \
--cc=azeemshaikh38@gmail.com \
--cc=jansimon.moeller@gmx.de \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).