[PATCH] dt-bindings: backlight: pwm: Make power-supply not required

[PATCH] dt-bindings: backlight: pwm: Make power-supply not required

[Geert Uytterhoeven]

make dtbs_check:

    arch/arm/boot/dts/renesas/r8a7742-iwg21d-q7.dtb: backlight: 'power-supply' is a required property
	    From schema: Documentation/devicetree/bindings/leds/backlight/pwm-backlight.yaml

As that backlight device node already has an "enable-gpios" property to
control the power supplied to the backlight, it sounds a bit silly to
have to add a "power-supply" property just to silence this warning.  In
addition, as of commit deaeeda2051fa280 ("backlight: pwm_bl: Don't rely
on a disabled PWM emiting inactive state"), the Linux driver considers
the power supply optional.

Fix this by synchronizing the bindings with actual driver behavior by
making the "power-supply" optional.

Fixes: deaeeda2051fa280 ("backlight: pwm_bl: Don't rely on a disabled PWM emiting inactive state")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
As commit deaeeda2051fa280 was only upstreamed in v6.3, I'm wondering if
the backlight on the iWave Systems RainboW-G20D/G21D Qseven and
RainboW-G22D-SODIMM boards worked before?  I don't have the hardware.

Thanks!
---
 .../devicetree/bindings/leds/backlight/pwm-backlight.yaml        | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.yaml
index 5ec47a8c6568b60e..53569028899020d6 100644
--- a/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.yaml
+++ b/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.yaml
@@ -68,7 +68,6 @@ dependencies:
 required:
   - compatible
   - pwms
-  - power-supply
 
 additionalProperties: false
 
-- 
2.34.1

Re: [PATCH] dt-bindings: backlight: pwm: Make power-supply not required

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1998 bytes --]

On Tue, May 23, 2023 at 05:38:37PM +0200, Geert Uytterhoeven wrote:
> make dtbs_check:
> 
>     arch/arm/boot/dts/renesas/r8a7742-iwg21d-q7.dtb: backlight: 'power-supply' is a required property
> 	    From schema: Documentation/devicetree/bindings/leds/backlight/pwm-backlight.yaml
> 
> As that backlight device node already has an "enable-gpios" property to
> control the power supplied to the backlight, it sounds a bit silly to
> have to add a "power-supply" property just to silence this warning.  In
> addition, as of commit deaeeda2051fa280 ("backlight: pwm_bl: Don't rely
> on a disabled PWM emiting inactive state"), the Linux driver considers
> the power supply optional.
> 
> Fix this by synchronizing the bindings with actual driver behavior by
> making the "power-supply" optional.

That seems to follow from reading the aforementioned commit.
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> 
> Fixes: deaeeda2051fa280 ("backlight: pwm_bl: Don't rely on a disabled PWM emiting inactive state")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> As commit deaeeda2051fa280 was only upstreamed in v6.3, I'm wondering if
> the backlight on the iWave Systems RainboW-G20D/G21D Qseven and
> RainboW-G22D-SODIMM boards worked before?  I don't have the hardware.
> 
> Thanks!
> ---
>  .../devicetree/bindings/leds/backlight/pwm-backlight.yaml        | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.yaml
> index 5ec47a8c6568b60e..53569028899020d6 100644
> --- a/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.yaml
> +++ b/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.yaml
> @@ -68,7 +68,6 @@ dependencies:
>  required:
>    - compatible
>    - pwms
> -  - power-supply
>  
>  additionalProperties: false
>  
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] dt-bindings: backlight: pwm: Make power-supply not required

[Lee Jones]

On Tue, 23 May 2023, Geert Uytterhoeven wrote:

> make dtbs_check:
> 
>     arch/arm/boot/dts/renesas/r8a7742-iwg21d-q7.dtb: backlight: 'power-supply' is a required property
> 	    From schema: Documentation/devicetree/bindings/leds/backlight/pwm-backlight.yaml
> 
> As that backlight device node already has an "enable-gpios" property to
> control the power supplied to the backlight, it sounds a bit silly to
> have to add a "power-supply" property just to silence this warning.  In
> addition, as of commit deaeeda2051fa280 ("backlight: pwm_bl: Don't rely
> on a disabled PWM emiting inactive state"), the Linux driver considers
> the power supply optional.
> 
> Fix this by synchronizing the bindings with actual driver behavior by
> making the "power-supply" optional.
> 
> Fixes: deaeeda2051fa280 ("backlight: pwm_bl: Don't rely on a disabled PWM emiting inactive state")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> As commit deaeeda2051fa280 was only upstreamed in v6.3, I'm wondering if
> the backlight on the iWave Systems RainboW-G20D/G21D Qseven and
> RainboW-G22D-SODIMM boards worked before?  I don't have the hardware.
> 
> Thanks!
> ---
>  .../devicetree/bindings/leds/backlight/pwm-backlight.yaml        | 1 -
>  1 file changed, 1 deletion(-)

Applied, thanks

-- 
Lee Jones [李琼斯]