From: Lee Jones <lee@kernel.org>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: pavel@ucw.cz, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] leds: cht-wcove: Fix an unsigned comparison which can never be negative
Date: Thu, 8 Jun 2023 17:38:12 +0100 [thread overview]
Message-ID: <20230608163812.GC3572061@google.com> (raw)
In-Reply-To: <20230531020238.102684-1-yang.lee@linux.alibaba.com>
On Wed, 31 May 2023, Yang Li wrote:
> The return value from the call to cht_wc_leds_find_freq() is int.
> However, the return value is being assigned to an unsigned
> int variable 'ctrl', so making it an int.
>
> Eliminate the following warning:
> drivers/leds/leds-cht-wcove.c:236 cht_wc_leds_set_effect() warn: unsigned 'ctrl' is never less than zero.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5341
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/leds/leds-cht-wcove.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied, thanks
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2023-06-08 16:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 2:02 [PATCH -next] leds: cht-wcove: Fix an unsigned comparison which can never be negative Yang Li
2023-06-08 16:38 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230608163812.GC3572061@google.com \
--to=lee@kernel.org \
--cc=abaci@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).