From: Pavel Machek <pavel@ucw.cz>
To: Marek Beh??n <kabel@kernel.org>
Cc: linux-leds@vger.kernel.org, Lee Jones <lee@kernel.org>
Subject: Re: [PATCH v2 1/3] leds: turris-omnia: change max brightness from 255 to 1
Date: Sun, 16 Jul 2023 11:19:30 +0200 [thread overview]
Message-ID: <20230716091929.GA1182@bug> (raw)
In-Reply-To: <20230714085253.13544-2-kabel@kernel.org>
Hi!
> Using binary brightness makes more sense for this controller, because
> internally in the MCU it works that way: the LED has a color, and a
> state whether it is ON or OFF.
So, controller can do (1, 3, 5) but not (3, 3, 3)?
> The resulting brightness computation with led_mc_calc_color_components()
> will now always result in either (0, 0, 0) or the multi_intensity value.
Won't that limit you to 8 colors total?
I guess I`m confused how this hw works...
Best regards,
Pavel
> init_data.fwnode = &np->fwnode;
>
> cdev = &led->mc_cdev.led_cdev;
> - cdev->max_brightness = 255;
> + cdev->max_brightness = 1;
> cdev->brightness_set_blocking = omnia_led_brightness_set_blocking;
>
> /* put the LED into software mode */
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2023-07-16 9:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 8:52 [PATCH v2 0/3] leds: turris-omnia: updates Marek Behún
2023-07-14 8:52 ` [PATCH v2 1/3] leds: turris-omnia: change max brightness from 255 to 1 Marek Behún
2023-07-16 9:19 ` Pavel Machek [this message]
2023-07-16 15:01 ` Marek Behún
2023-07-28 9:56 ` Lee Jones
2023-07-28 10:10 ` Pavel Machek
2023-08-01 9:07 ` Marek Behún
2023-07-14 8:52 ` [PATCH v2 2/3] leds: turris-omnia: initialize multi-intensity to full Marek Behún
2023-07-16 9:19 ` Pavel Machek
2023-07-14 8:52 ` [PATCH v2 3/3] leds: turris-omnia: support HW controlled mode via private trigger Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230716091929.GA1182@bug \
--to=pavel@ucw.cz \
--cc=kabel@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox