From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E178AEB64DD for ; Sun, 16 Jul 2023 09:19:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229679AbjGPJTp (ORCPT ); Sun, 16 Jul 2023 05:19:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229665AbjGPJTn (ORCPT ); Sun, 16 Jul 2023 05:19:43 -0400 Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB21BB9 for ; Sun, 16 Jul 2023 02:19:42 -0700 (PDT) Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 66B8C1C0DC0; Sun, 16 Jul 2023 11:19:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1; t=1689499181; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KGRnUWSOrF4xbLGBV4fkGSEh84VbSJE45mJ4uNCJAbQ=; b=TTvrrknLzpzo7/lockp8w0OtXyNsKK6WrqDDRErOqNV452SM1tp7tZ0AhgWHzY64DNBwyR bmbmdgETBAqIkpvdvejCB8yFsLCspyQIOjYfXKZs+ve3PUPt0+BT72Y8PLXLedHu0J935S ZDMh3MK0nm7f0j9rwA819W4cTQguQbM= Date: Sun, 16 Jul 2023 11:19:40 +0200 From: Pavel Machek To: Marek Beh??n Cc: linux-leds@vger.kernel.org, Lee Jones Subject: Re: [PATCH v2 2/3] leds: turris-omnia: initialize multi-intensity to full Message-ID: <20230716091940.GB1182@bug> References: <20230714085253.13544-1-kabel@kernel.org> <20230714085253.13544-3-kabel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230714085253.13544-3-kabel@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Fri 2023-07-14 10:52:52, Marek Beh??n wrote: > The default color of each LED before driver probe is (255, 255, 255). > Initialize multi_intensity to this value, so that it corresponds to the > reality. > > Signed-off-by: Marek Beh??n Reviewed-by: Pavel Machek > +++ b/drivers/leds/leds-turris-omnia.c > @@ -98,10 +98,13 @@ static int omnia_led_register(struct i2c_client *client, struct omnia_led *led, > } > > led->subled_info[0].color_index = LED_COLOR_ID_RED; > + led->subled_info[0].intensity = 255; > led->subled_info[0].channel = 0; > led->subled_info[1].color_index = LED_COLOR_ID_GREEN; > + led->subled_info[1].intensity = 255; > led->subled_info[1].channel = 1; > led->subled_info[2].color_index = LED_COLOR_ID_BLUE; > + led->subled_info[2].intensity = 255; > led->subled_info[2].channel = 2; > > led->mc_cdev.subled_info = led->subled_info; > -- > 2.41.0 -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html