From: "Marek Behún" <kabel@kernel.org>
To: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
linux-leds@vger.kernel.org
Cc: "Marek Behún" <kabel@kernel.org>
Subject: [PATCH v3 3/6] leds: turris-omnia: use sysfs_emit() instead of sprintf()
Date: Wed, 2 Aug 2023 18:07:45 +0200 [thread overview]
Message-ID: <20230802160748.11208-4-kabel@kernel.org> (raw)
In-Reply-To: <20230802160748.11208-1-kabel@kernel.org>
Use the dedicated sysfs_emit() function instead of sprintf() in sysfs
attribute accessor brightness_show().
Signed-off-by: Marek Behún <kabel@kernel.org>
---
drivers/leds/leds-turris-omnia.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/leds-turris-omnia.c b/drivers/leds/leds-turris-omnia.c
index bb2a2b411a56..9fca0acb2270 100644
--- a/drivers/leds/leds-turris-omnia.c
+++ b/drivers/leds/leds-turris-omnia.c
@@ -196,7 +196,7 @@ static ssize_t brightness_show(struct device *dev, struct device_attribute *a,
if (ret < 0)
return ret;
- return sprintf(buf, "%d\n", ret);
+ return sysfs_emit(buf, "%d\n", ret);
}
static ssize_t brightness_store(struct device *dev, struct device_attribute *a,
--
2.41.0
next prev parent reply other threads:[~2023-08-02 16:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 16:07 [PATCH v3 0/6] leds: turris-omnia: updates Marek Behún
2023-08-02 16:07 ` [PATCH v3 1/6] leds: turris-omnia: drop unnecessary mutex locking Marek Behún
2023-08-18 8:09 ` Lee Jones
2023-08-18 9:23 ` (subset) " Lee Jones
2023-08-02 16:07 ` [PATCH v3 2/6] leds: turris-omnia: do not use SMBUS calls Marek Behún
2023-08-18 8:08 ` Lee Jones
2023-08-21 10:01 ` Marek Behún
2023-08-21 12:45 ` Lee Jones
2023-08-02 16:07 ` Marek Behún [this message]
2023-08-18 9:18 ` (subset) [PATCH v3 3/6] leds: turris-omnia: use sysfs_emit() instead of sprintf() Lee Jones
2023-08-02 16:07 ` [PATCH v3 4/6] leds: turris-omnia: make set_brightness() more efficient Marek Behún
2023-08-18 9:42 ` Lee Jones
2023-08-21 10:14 ` Marek Behún
2023-08-21 12:39 ` Lee Jones
2023-08-02 16:07 ` [PATCH v3 5/6] leds: turris-omnia: support HW controlled mode via private trigger Marek Behún
2023-08-02 16:13 ` Marek Behún
2023-08-18 8:00 ` Lee Jones
2023-08-18 21:12 ` Jacek Anaszewski
2023-08-21 8:15 ` Lee Jones
2023-08-18 9:09 ` Lee Jones
2023-08-21 10:34 ` Marek Behún
2023-08-21 12:36 ` Lee Jones
2023-08-02 16:07 ` [PATCH v3 6/6] leds: turris-omnia: add support for enabling/disabling HW gamma correction Marek Behún
2023-08-18 10:30 ` Lee Jones
2023-08-21 10:46 ` Marek Behún
2023-08-21 12:26 ` Lee Jones
2023-08-14 7:33 ` [PATCH v3 0/6] leds: turris-omnia: updates Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230802160748.11208-4-kabel@kernel.org \
--to=kabel@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).