From: Lee Jones <lee@kernel.org>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Pavel Machek <pavel@ucw.cz>,
linux-leds@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] leds: pca955x: Convert enum->pointer for data in the match tables
Date: Mon, 21 Aug 2023 13:19:07 +0100 [thread overview]
Message-ID: <20230821121907.GI1380343@google.com> (raw)
In-Reply-To: <20230820082005.55124-1-biju.das.jz@bp.renesas.com>
On Sun, 20 Aug 2023, Biju Das wrote:
> Convert enum->pointer for data in the match tables, so that
> device_get_match_data() can do match against OF/ACPI/I2C tables, once i2c
> bus type match support added to it.
>
> Replace enum->struct *pca955x_chipdefs for data in the match table.
> Simplify the probe() by replacing device_get_match_data() and ID lookup
> for retrieving data by i2c_get_match_data().
>
> While at it, add const definition to pca955x_chipdefs[].
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> Note:
> This patch is only compile tested.
> ---
> drivers/leds/leds-pca955x.c | 45 +++++++++++++------------------------
> 1 file changed, 16 insertions(+), 29 deletions(-)
This is too big of a change to be added this late in the cycle.
Especially since this is only compile tested.
Pushing review until after v6.5 is out.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-08-21 12:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-20 8:20 [PATCH] leds: pca955x: Convert enum->pointer for data in the match tables Biju Das
2023-08-21 12:19 ` Lee Jones [this message]
2023-08-21 12:25 ` Biju Das
2023-09-19 15:00 ` Lee Jones
2023-09-20 6:20 ` Biju Das
2023-09-28 13:44 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230821121907.GI1380343@google.com \
--to=lee@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-leds@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox