Linux LED subsystem development
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: "Marek Behún" <kabel@kernel.org>
Cc: linux-leds@vger.kernel.org
Subject: Re: [PATCH] leds: turris-omnia: Fix unused variable
Date: Fri, 22 Sep 2023 07:59:19 +0100	[thread overview]
Message-ID: <20230922065919.GA3660432@google.com> (raw)
In-Reply-To: <20230921205025.20303-1-kabel@kernel.org>

On Thu, 21 Sep 2023, Marek Behún wrote:

> The variable ret is not used in this function.
> 
> Fixes: 28350bc0ac77 ("leds: turris-omnia: Do not use SMBUS calls")
> Closes: https://lore.kernel.org/linux-leds/202309212215.Yl5VQaSm-lkp@intel.com/T/#u
> Signed-off-by: Marek Behún <kabel@kernel.org>
> ---
>  drivers/leds/leds-turris-omnia.c | 1 -
>  1 file changed, 1 deletion(-)

I already fixed and squashed this.

How was this missed when you tested the set?

-- 
Lee Jones [李琼斯]

  reply	other threads:[~2023-09-22  6:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-21 20:50 [PATCH] leds: turris-omnia: Fix unused variable Marek Behún
2023-09-22  6:59 ` Lee Jones [this message]
2023-09-22 11:16   ` Marek Behún
2023-09-25  7:53     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230922065919.GA3660432@google.com \
    --to=lee@kernel.org \
    --cc=kabel@kernel.org \
    --cc=linux-leds@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox