From: Lee Jones <lee@kernel.org>
To: Chunyan Zhang <chunyan.zhang@unisoc.com>
Cc: Pavel Machek <pavel@ucw.cz>,
linux-leds@vger.kernel.org,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Orson Zhai <orsonzhai@gmail.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] leds: sc27xx: Move mutex_init() to the end of probe
Date: Thu, 28 Sep 2023 14:37:56 +0100 [thread overview]
Message-ID: <20230928133756.GI9999@google.com> (raw)
In-Reply-To: <20230925032453.724518-1-chunyan.zhang@unisoc.com>
On Mon, 25 Sep 2023, Chunyan Zhang wrote:
> Move the mutex_init() to avoid redundant mutex_destroy() calls after
> that for each time the probe fails.
>
> Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
> ---
> V2:
> - Move the mutex_init() to the end of .probe() instead of adding
> mutex_destroy() according to Lee's comments.
> ---
> drivers/leds/leds-sc27xx-bltc.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
Nice patch, but doesn't apply.
Please rebase (onto linux-next or for-leds-next) and resend.
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2023-09-28 13:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 3:24 [PATCH V2] leds: sc27xx: Move mutex_init() to the end of probe Chunyan Zhang
2023-09-28 13:37 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230928133756.GI9999@google.com \
--to=lee@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=chunyan.zhang@unisoc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=pavel@ucw.cz \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).