From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-leds-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id C573FE732D0
	for <linux-leds@archiver.kernel.org>; Thu, 28 Sep 2023 13:38:04 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231966AbjI1NiE (ORCPT <rfc822;linux-leds@archiver.kernel.org>);
        Thu, 28 Sep 2023 09:38:04 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40940 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S231868AbjI1NiD (ORCPT
        <rfc822;linux-leds@vger.kernel.org>); Thu, 28 Sep 2023 09:38:03 -0400
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D00292;
        Thu, 28 Sep 2023 06:38:01 -0700 (PDT)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7874BC433C7;
        Thu, 28 Sep 2023 13:37:59 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1695908281;
        bh=tNJPrSt0EbpYHgUGMbTFOG600cX1nU2foR/sWCpczbM=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=JmPchohDyoQ6K0w5lf2CBErfA/MK9ZiuDsSClS02RQTKpm36prB0Afz4G9prWxgNa
         zgGeel0htRoZnDUpGT4kmqcI2+KZRs9cFvwT0ehSaIGNBeAW8Dc0bsBO3BQlkbatOT
         i4k/EEVwrJYA0nUP309m89dkrCztL/rL0tDyQhPfNkvWsANgU7Fh9lbCD8d/JiXsVW
         slyMxycwEMCZaz1BypRUfJMMjdsZT9zNTNky6UjK6O6cvdEhNEdjRkpkXAa30ZnQCt
         SRj1FE2QRYTSonX4Xp3UJTt6QdqRh4+cD3+XMupimFUtT8NVq38xwuDUBdeLE9m6KG
         IClVlEMWWIgFQ==
Date:   Thu, 28 Sep 2023 14:37:56 +0100
From:   Lee Jones <lee@kernel.org>
To:     Chunyan Zhang <chunyan.zhang@unisoc.com>
Cc:     Pavel Machek <pavel@ucw.cz>, linux-leds@vger.kernel.org,
        Baolin Wang <baolin.wang@linux.alibaba.com>,
        Orson Zhai <orsonzhai@gmail.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] leds: sc27xx: Move mutex_init() to the end of probe
Message-ID: <20230928133756.GI9999@google.com>
References: <20230925032453.724518-1-chunyan.zhang@unisoc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230925032453.724518-1-chunyan.zhang@unisoc.com>
Precedence: bulk
List-ID: <linux-leds.vger.kernel.org>
X-Mailing-List: linux-leds@vger.kernel.org

On Mon, 25 Sep 2023, Chunyan Zhang wrote:

> Move the mutex_init() to avoid redundant mutex_destroy() calls after
> that for each time the probe fails.
> 
> Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
> ---
> V2:
> - Move the mutex_init() to the end of .probe() instead of adding
> mutex_destroy() according to Lee's comments.
> ---
>  drivers/leds/leds-sc27xx-bltc.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)

Nice patch, but doesn't apply.

Please rebase (onto linux-next or for-leds-next) and resend.

-- 
Lee Jones [李琼斯]