From: Dmitry Rokosov <ddrokosov@salutedevices.com>
To: <lee@kernel.org>, <pavel@ucw.cz>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<andy.shevchenko@gmail.com>
Cc: <kernel@sberdevices.ru>, <rockosov@gmail.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-leds@vger.kernel.org>,
George Stark <gnstark@salutedevices.com>,
Dmitry Rokosov <ddrokosov@salutedevices.com>
Subject: [PATCH v2 06/11] leds: aw200xx: add delay after software reset
Date: Wed, 18 Oct 2023 21:29:38 +0300 [thread overview]
Message-ID: <20231018182943.18700-7-ddrokosov@salutedevices.com> (raw)
In-Reply-To: <20231018182943.18700-1-ddrokosov@salutedevices.com>
From: George Stark <gnstark@salutedevices.com>
According to datasheets of aw200xx devices software reset takes at
least 1 ms so add delay after reset before issuing commands to device.
Signed-off-by: George Stark <gnstark@salutedevices.com>
Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com>
---
drivers/leds/leds-aw200xx.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/leds/leds-aw200xx.c b/drivers/leds/leds-aw200xx.c
index a2a31b8e623e..77760406abbf 100644
--- a/drivers/leds/leds-aw200xx.c
+++ b/drivers/leds/leds-aw200xx.c
@@ -321,6 +321,9 @@ static int aw200xx_chip_reset(const struct aw200xx *const chip)
if (ret)
return ret;
+ /* according to datasheet software reset takes at least 1 ms */
+ fsleep(1000);
+
regcache_mark_dirty(chip->regmap);
return regmap_write(chip->regmap, AW200XX_REG_FCD, AW200XX_FCD_CLEAR);
}
--
2.36.0
next prev parent reply other threads:[~2023-10-18 18:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 18:29 [PATCH v2 00/11] leds: aw200xx: several driver updates Dmitry Rokosov
2023-10-18 18:29 ` [PATCH v2 01/11] leds: aw200xx: fix write to DIM parameter Dmitry Rokosov
2023-10-18 18:29 ` [PATCH v2 02/11] leds: aw200xx: support HWEN hardware control Dmitry Rokosov
2023-10-19 8:56 ` Andy Shevchenko
2023-10-18 18:29 ` [PATCH v2 03/11] dt-bindings: leds: aw200xx: introduce optional hwen-gpios property Dmitry Rokosov
2023-10-19 14:11 ` Conor Dooley
2023-10-24 18:54 ` Dmitry Rokosov
2023-10-24 18:30 ` Rob Herring
2023-10-24 18:52 ` [DMARC error] " Dmitry Rokosov
2023-10-25 7:58 ` Krzysztof Kozlowski
2023-10-18 18:29 ` [PATCH v2 04/11] leds: aw200xx: calculate dts property display_rows in driver Dmitry Rokosov
2023-10-19 9:01 ` Andy Shevchenko
2023-10-19 19:25 ` George Stark
2023-10-18 18:29 ` [PATCH v2 05/11] dt-bindings: leds: aw200xx: remove property "awinic,display-rows" Dmitry Rokosov
2023-10-18 18:29 ` Dmitry Rokosov [this message]
2023-10-19 9:03 ` [PATCH v2 06/11] leds: aw200xx: add delay after software reset Andy Shevchenko
2023-10-18 18:29 ` [PATCH v2 07/11] leds: aw200xx: enable disable_locking flag in regmap config Dmitry Rokosov
2023-10-18 18:29 ` [PATCH v2 08/11] leds: aw200xx: improve autodim calculation method Dmitry Rokosov
2023-10-18 18:29 ` [PATCH v2 09/11] leds: aw200xx: add support for aw20108 device Dmitry Rokosov
2023-10-19 9:10 ` Andy Shevchenko
2023-10-19 9:12 ` Andy Shevchenko
2023-10-18 18:29 ` [PATCH v2 10/11] dt-bindings: leds: awinic,aw200xx: add AW20108 device Dmitry Rokosov
2023-10-19 14:07 ` Conor Dooley
2023-10-18 18:29 ` [PATCH v2 11/11] dt-bindings: leds: aw200xx: fix led pattern and add reg constraints Dmitry Rokosov
2023-10-19 14:08 ` Conor Dooley
2023-10-24 18:56 ` Dmitry Rokosov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231018182943.18700-7-ddrokosov@salutedevices.com \
--to=ddrokosov@salutedevices.com \
--cc=andy.shevchenko@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gnstark@salutedevices.com \
--cc=kernel@sberdevices.ru \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=rockosov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox