From: Florian Eckert <fe@dev.tdt.de>
To: Eckert.Florian@googlemail.com, gregkh@linuxfoundation.org,
jirislaby@kernel.org, pavel@ucw.cz, lee@kernel.org,
kabel@kernel.org, u.kleine-koenig@pengutronix.de,
m.brock@vanmierlo.com
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: [Patch v6 3/7] leds: ledtrig-tty: free allocated ttyname buffer on deactivate
Date: Mon, 30 Oct 2023 11:04:43 +0100 [thread overview]
Message-ID: <20231030100447.63477-4-fe@dev.tdt.de> (raw)
In-Reply-To: <20231030100447.63477-1-fe@dev.tdt.de>
The ttyname buffer for the ledtrig_tty_data struct is allocated in the
sysfs ttyname_store() function. This buffer must be released on trigger
deactivation. This was missing and is thus a memory leak.
While we are at it, the tty handler in the ledtrig_tty_data struct should
also be returned in case of the trigger deactivation call.
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
---
drivers/leds/trigger/ledtrig-tty.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/leds/trigger/ledtrig-tty.c b/drivers/leds/trigger/ledtrig-tty.c
index 8ae0d2d284af..3e69a7bde928 100644
--- a/drivers/leds/trigger/ledtrig-tty.c
+++ b/drivers/leds/trigger/ledtrig-tty.c
@@ -168,6 +168,10 @@ static void ledtrig_tty_deactivate(struct led_classdev *led_cdev)
cancel_delayed_work_sync(&trigger_data->dwork);
+ kfree(trigger_data->ttyname);
+ tty_kref_put(trigger_data->tty);
+ trigger_data->tty = NULL;
+
kfree(trigger_data);
}
--
2.30.2
next prev parent reply other threads:[~2023-10-30 10:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 10:04 [Patch v6 0/8] ledtrig-tty: add additional tty state evaluation Florian Eckert
2023-10-30 10:04 ` [Patch v6 1/7] tty: whitespaces in descriptions corrected by replacing tabs with spaces Florian Eckert
2023-10-30 10:04 ` [Patch v6 2/7] tty: add new helper function tty_get_tiocm Florian Eckert
2023-10-30 10:04 ` Florian Eckert [this message]
2023-11-04 13:25 ` [Patch v6 3/7] leds: ledtrig-tty: free allocated ttyname buffer on deactivate m.brock
2023-10-30 10:04 ` [Patch v6 4/7] leds: ledtrig-tty: change logging if get icount failed Florian Eckert
2023-10-30 10:04 ` [Patch v6 5/7] leds: ledtrig-tty: replace mutex with completion Florian Eckert
2023-10-30 10:04 ` [Patch v6 6/7] leds: ledtrig-tty: make rx tx activitate configurable Florian Eckert
2023-10-30 10:04 ` [Patch v6 7/7] leds: ledtrig-tty: add additional line state evaluation Florian Eckert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231030100447.63477-4-fe@dev.tdt.de \
--to=fe@dev.tdt.de \
--cc=Eckert.Florian@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kabel@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=m.brock@vanmierlo.com \
--cc=pavel@ucw.cz \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).