From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0C33C4332F for ; Tue, 31 Oct 2023 18:03:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231195AbjJaSDK (ORCPT ); Tue, 31 Oct 2023 14:03:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230455AbjJaSDJ (ORCPT ); Tue, 31 Oct 2023 14:03:09 -0400 Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 788F792; Tue, 31 Oct 2023 11:03:07 -0700 (PDT) Received: by mail-ot1-f52.google.com with SMTP id 46e09a7af769-6ce2cf67be2so3752692a34.2; Tue, 31 Oct 2023 11:03:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698775387; x=1699380187; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JBWbi7Y3InN0amfRzl58wtob2sEve30Z46Ww/SB9XT4=; b=PUCzUqXeEw9DUaJJe1hcXtjnkXpMbHkNcLV3hd2sbEiWD8ZxNQ/owISVzb1IN9kfxo jy/AmIWmb6w8LpzUhgScdMK2UbId0mkwT0c/X8mnJXghjLTuCSzxUO+QhoGv97cgWJPW fLifm0s4TU5YtMP0zweu8A2Xr7A5qEDAqeiQNidRxsDMVMf1Ixb1PMPP9tllNi07YNWZ FkZqeWnaT3G1R0WRBZHrkZltdLxHT080LvEBSEBq8GSENOZ7VSzVgOnczKaWDeulWj4v trvQZ9U/BmqjzmZY+jwQOLKptvy+wj8v5mUIMwuRNWYYYsEbnJipxCWtj4tF335JOqjf 8K5Q== X-Gm-Message-State: AOJu0YzaeiW40OuEagHBTlD1S1gh4OKWIxT1fspOsQ6cUojP/O9bUhLc Or4bvQ6YFV+lcpXL1+JsdQ== X-Google-Smtp-Source: AGHT+IFDmYyfKEScG+IjynXcRP20bxlv/OFOAsa8+QIiCzBhwpfmGNXYpoE8KH5Q0d2rdGE8CuRIww== X-Received: by 2002:a05:6870:1004:b0:1d0:d78b:982e with SMTP id 4-20020a056870100400b001d0d78b982emr12693903oai.35.1698775386709; Tue, 31 Oct 2023 11:03:06 -0700 (PDT) Received: from herring.priv ([4.31.143.193]) by smtp.gmail.com with ESMTPSA id ds48-20020a0568705b3000b001efce0658e6sm367856oab.39.2023.10.31.11.03.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Oct 2023 11:03:06 -0700 (PDT) Received: (nullmailer pid 1823980 invoked by uid 1000); Tue, 31 Oct 2023 18:03:05 -0000 Date: Tue, 31 Oct 2023 13:03:05 -0500 From: Rob Herring To: Shiji Yang Cc: devicetree@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Pavel Machek , Lee Jones , Krzysztof Kozlowski , Conor Dooley , Olliver Schinagl Subject: Re: [PATCH v2 2/2] dt-bindings: leds: add "internet" and "rssi" function definitions Message-ID: <20231031180305.GA1813504-robh@kernel.org> References: <20231031132901.11732-1-yangshiji66@outlook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Tue, Oct 31, 2023 at 09:29:01PM +0800, Shiji Yang wrote: > These two types of LEDs are widely used in routers and NICs. The > RSSI (Received Signal Strength Indicator) LED is used to display > the Wi-Fi signal strength, and the Internet LED can indicate > whether the device can access a specific server. > > Signed-off-by: Shiji Yang > --- > include/dt-bindings/leds/common.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h > index 9a0d33d02..55a426e39 100644 > --- a/include/dt-bindings/leds/common.h > +++ b/include/dt-bindings/leds/common.h > @@ -88,11 +88,13 @@ > #define LED_FUNCTION_FLASH "flash" > #define LED_FUNCTION_HEARTBEAT "heartbeat" > #define LED_FUNCTION_INDICATOR "indicator" > +#define LED_FUNCTION_INTERNET "internet" Duplicate of 'wan'. > #define LED_FUNCTION_LAN "lan" > #define LED_FUNCTION_MAIL "mail" > #define LED_FUNCTION_MTD "mtd" > #define LED_FUNCTION_PANIC "panic" > #define LED_FUNCTION_PROGRAMMING "programming" > +#define LED_FUNCTION_RSSI "rssi" 'rx' or 'wlan'? Wouldn't you need multiple LEDs to indicate signal strength? Maybe 'signal' or something would be more generic? > #define LED_FUNCTION_RX "rx" > #define LED_FUNCTION_SD "sd" > #define LED_FUNCTION_STANDBY "standby" > -- > 2.39.2 >