From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C801F56770; Tue, 21 Nov 2023 15:23:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dMEbXrc1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12F0BC433C8; Tue, 21 Nov 2023 15:23:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700580222; bh=fFJ7ZJrRFt5fAgZndYTrEnrlMNAWYHpdqnI+TcUaVK4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dMEbXrc1JJ1TccZBV6p7x82//pScEYR0JK366Ug6MKYZWxxjEhS73HuPd77Rj+Whp cE6VtgpJ/zcMxEltGH7AbrpOg72d/44GYUt4o7NWrtbva825FbE39VkFdJs7ZwWn/H G76EYPHgRyjCDllwL7glRh1VtgVZMzXfls+wlRm/r8D7k9+zI647IrIsjArjOzk+PR CbGKyD9ctfhbbVX67jenib/bHHV1Hhd3V70hWyj14IX1EOQUf40dFrl3DF1SEok6tM o0nQVAEdRZNZcS924rZhkWWM1kvM/mE7GoUW9xOBKYf4kWLt6gKYdLYeIRh6bQMOqr dMsk4dTOG+N8w== Date: Tue, 21 Nov 2023 15:23:36 +0000 From: Lee Jones To: Florian Eckert Cc: m.brock@vanmierlo.com, Eckert.Florian@googlemail.com, gregkh@linuxfoundation.org, jirislaby@kernel.org, pavel@ucw.cz, kabel@kernel.org, u.kleine-koenig@pengutronix.de, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [Patch v8 6/6] leds: ledtrig-tty: add additional line state evaluation Message-ID: <20231121152336.GC173820@google.com> References: <20231109085038.371977-1-fe@dev.tdt.de> <20231109085038.371977-7-fe@dev.tdt.de> <39e7c892299c74821b1105a0967063ca@vanmierlo.com> <20231117121253.GB137434@google.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, 20 Nov 2023, Florian Eckert wrote: > > > On 2023-11-17 13:12, Lee Jones wrote: > > On Thu, 09 Nov 2023, m.brock@vanmierlo.com wrote: > > > > > Florian Eckert schreef op 2023-11-09 09:50: > > > > The serial tty interface also supports additional input signals, that > > > > can also be evaluated within this trigger. This change is adding the > > > > following additional input sources, which could be controlled > > > > via the '/sys/class//' sysfs interface. > > > > > > > > Explanation: > > > > DCE = Data Communication Equipment (Modem) > > > > DTE = Data Terminal Equipment (Computer) > > > > > > > > - cts: > > > > DCE is ready to accept data from the DTE (CTS = Clear To Send). If > > > > the line state is detected, the LED is switched on. > > > > If set to 0 (default), the LED will not evaluate CTS. > > > > If set to 1, the LED will evaluate CTS. > > > > > > > > - dsr: > > > > DCE is ready to receive and send data (DSR = Data Set Ready). If the > > > > line state is detected, the LED is switched on. > > > > If set to 0 (default), the LED will not evaluate DSR. > > > > If set to 1, the LED will evaluate DSR. > > > > > > > > - dcd: > > > > DTE is receiving a carrier from the DCE (DCD = Data Carrier Detect). > > > > If the line state is detected, the LED is switched on. > > > > If set to 0 (default), the LED will not evaluate DCD. > > > > If set to 1, the LED will evaluate DCD. > > > > > > > > - rng: > > > > DCE has detected an incoming ring signal on the telephone line > > > > (RNG = Ring Indicator). If the line state is detected, the LED is > > > > switched on. > > > > If set to 0 (default), the LED will not evaluate RNG. > > > > If set to 1, the LED will evaluate RNG. > > > > > > > > Also add an invert flag on LED blink, so that the LED blinks in the > > > > correct order. > > > > > > > > * If one off the new enabled input signals are evaluatet as 'enabled', > > > > and data are transmitted, then the LED should first blink 'off' and > > > > then 'on' (invert). > > > > * If all the new enabled input signals are evaluatet as 'disabled', > > > > and data are transmitted, then the LED should first blink 'on' and > > > > then 'off'. > > > > > > > > Signed-off-by: Florian Eckert > > > > --- > > > > .../ABI/testing/sysfs-class-led-trigger-tty | 40 ++++++++++ > > > > drivers/leds/trigger/ledtrig-tty.c | 77 ++++++++++++++++++- > > > > 2 files changed, 116 insertions(+), 1 deletion(-) > > > > [...] > > > > > Reviewed-by: Maarten Brock > > > > Please snip your replies. > > Is there anything I can do? Or do I have to do something? Please give me > more detailed instructions That instruction wasn't for you. This patch is still on my INCOMING list. Do you have Greg's blessing yet? -- Lee Jones [李琼斯]