From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Patrick Rudolph <patrick.rudolph@9elements.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>
Subject: [PATCH v1 3/4] leds: max5970: Make use of dev_err_probe()
Date: Thu, 14 Dec 2023 20:40:10 +0200 [thread overview]
Message-ID: <20231214184050.1272848-4-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20231214184050.1272848-1-andriy.shevchenko@linux.intel.com>
Simplify the error handling in probe function by switching from
dev_err() to dev_err_probe().
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/leds/leds-max5970.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-max5970.c b/drivers/leds/leds-max5970.c
index de57b385b4f6..60db3c28d7d9 100644
--- a/drivers/leds/leds-max5970.c
+++ b/drivers/leds/leds-max5970.c
@@ -62,7 +62,7 @@ static int max5970_led_probe(struct platform_device *pdev)
continue;
if (reg >= MAX5970_NUM_LEDS) {
- dev_err(dev, "invalid LED (%u >= %d)\n", reg, MAX5970_NUM_LEDS);
+ dev_err_probe(dev, -EINVAL, "invalid LED (%u >= %d)\n", reg, MAX5970_NUM_LEDS);
continue;
}
@@ -86,8 +86,7 @@ static int max5970_led_probe(struct platform_device *pdev)
ret = devm_led_classdev_register(dev, &ddata->cdev);
if (ret < 0) {
fwnode_handle_put(child);
- dev_err(dev, "Failed to initialize LED %u\n", reg);
- return ret;
+ return dev_err_probe(dev, ret, "Failed to initialize LED %u\n", reg);
}
}
--
2.43.0.rc1.1.gbec44491f096
next prev parent reply other threads:[~2023-12-14 18:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 18:40 [PATCH v1 0/4] leds: max5970: Allow to use on non-OF platforms Andy Shevchenko
2023-12-14 18:40 ` [PATCH v1 1/4] leds: max5970: Remove unused variable Andy Shevchenko
2023-12-14 18:40 ` [PATCH v1 2/4] leds: max5970: Make use of device properties Andy Shevchenko
2023-12-14 18:40 ` Andy Shevchenko [this message]
2023-12-14 18:40 ` [PATCH v1 4/4] leds: max5970: Add missing headers Andy Shevchenko
2023-12-21 14:44 ` [PATCH v1 0/4] leds: max5970: Allow to use on non-OF platforms Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231214184050.1272848-4-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=patrick.rudolph@9elements.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox