From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A295732187 for ; Tue, 9 Jan 2024 08:37:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="G1e/mcjH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04E7CC433C7; Tue, 9 Jan 2024 08:37:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704789464; bh=zy9sSXfxLJbRplaZmzyTBLSlFgLOYFl9vybC0oLdcnQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G1e/mcjHS/l8SnDwFbmXUmw+qge4/we0MR4j6OEh2LaVgs8f8l9Iw0ggiyzL+F9CN yCA7DEXP8vr5QDhqqbsuNFfChLzTNnaD6LdxcKTcVw7vVY3/x7m7WsDgOsccnxrVen 7mZhKNsCWunniAcXfrzfdYI2KSaspf7wPmJgot6Cx0AbpD2tibqWTUuax1AkCsk4Ar YrGtTC8lzMbKGxyI+VnjTx1gXsJejRFR5NpzNG/rf5CSK+pZI4UqoLusW4vOkk7eXd sdZg3uIOQ4vrpAoOONmFGbthnvCs3vioBwZmp7X8uKvqFZUmBboSuwhFZgKXRDzc5l qB6NQxedJAQZQ== Date: Tue, 9 Jan 2024 08:37:39 +0000 From: Lee Jones To: Heiner Kallweit , arnd@arndb.de Cc: Pavel Machek , Andrew Lunn , "linux-leds@vger.kernel.org" Subject: Re: [PATCH] leds: Change devm_led_classdev_register_ext stub logic to use IS_REACHABLE Message-ID: <20240109083739.GE7948@google.com> References: <0f6f432b-c650-4bb8-a1b5-fe3372804d52@gmail.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0f6f432b-c650-4bb8-a1b5-fe3372804d52@gmail.com> On Thu, 28 Dec 2023, Heiner Kallweit wrote: > If CONFIG_LEDS_CLASS = m and the caller of devm_led_classdev_register > is built-in, we get a compile/link error. > To avoid this we could add conditional compiling to the caller, but > exactly this overhead we wanted to avoid with adding the stubs. > Easiest solution is to use the existing stub also in case IS_ENABLED > is true, but IS_REACHABLE is false. > > Fixes: 18764b883e15 ("r8169: add support for LED's on RTL8168/RTL8101") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202312281159.9TPeXbNd-lkp@intel.com/ > Signed-off-by: Heiner Kallweit > --- > include/linux/leds.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Arnd pretty much NACKed this, right? https://lore.kernel.org/r/b310230b-f20b-489a-97ed-908df193a942@app.fastmail.com > diff --git a/include/linux/leds.h b/include/linux/leds.h > index 4754b02d3..1eecee316 100644 > --- a/include/linux/leds.h > +++ b/include/linux/leds.h > @@ -279,7 +279,7 @@ static inline int led_classdev_register(struct device *parent, > return led_classdev_register_ext(parent, led_cdev, NULL); > } > > -#if IS_ENABLED(CONFIG_LEDS_CLASS) > +#if IS_REACHABLE(CONFIG_LEDS_CLASS) > int devm_led_classdev_register_ext(struct device *parent, > struct led_classdev *led_cdev, > struct led_init_data *init_data); > -- > 2.43.0 > -- Lee Jones [李琼斯]