From: Rob Herring <robh@kernel.org>
To: INAGAKI Hiroshi <musashino.open@gmail.com>
Cc: pavel@ucw.cz, lee@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Hauke Mehrtens <hauke@hauke-m.de>
Subject: Re: [PATCH 1/2] dt-bindings: leds: add LED_FUNCTION_MOBILE for mobile network
Date: Thu, 21 Mar 2024 08:55:02 -0500 [thread overview]
Message-ID: <20240321135502.GA1637678-robh@kernel.org> (raw)
In-Reply-To: <20240320124431.221-2-musashino.open@gmail.com>
On Wed, Mar 20, 2024 at 09:43:16PM +0900, INAGAKI Hiroshi wrote:
> Add LED_FUNCTION_MOBILE for LEDs that indicate status of mobile network
> connection.
> As an example, "Mobile" LEDs on IIJ SA-W2 indicate status (no signal,
> too low, low, good) of mobile network connection via dongle connected
> to USB port.
>
> Suggested-by: Hauke Mehrtens <hauke@hauke-m.de>
> Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com>
> ---
> include/dt-bindings/leds/common.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h
> index ecea167930d9..d4b8498bde7f 100644
> --- a/include/dt-bindings/leds/common.h
> +++ b/include/dt-bindings/leds/common.h
> @@ -91,6 +91,7 @@
> #define LED_FUNCTION_LAN "lan"
> #define LED_FUNCTION_MAIL "mail"
> #define LED_FUNCTION_MTD "mtd"
> +#define LED_FUNCTION_MOBILE "mobile"
Why doesn't "wan" work?
> #define LED_FUNCTION_PANIC "panic"
> #define LED_FUNCTION_PROGRAMMING "programming"
> #define LED_FUNCTION_RX "rx"
> --
> 2.25.1
>
next prev parent reply other threads:[~2024-03-21 13:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 12:43 [PATCH 0/2] dt-bindings: leds: add LED_FUNCTION_* mainly for router devices INAGAKI Hiroshi
2024-03-20 12:43 ` [PATCH 1/2] dt-bindings: leds: add LED_FUNCTION_MOBILE for mobile network INAGAKI Hiroshi
2024-03-21 13:55 ` Rob Herring [this message]
2024-03-21 14:28 ` INAGAKI Hiroshi
2024-03-20 12:43 ` [PATCH 2/2] dt-bindings: leds: add LED_FUNCTION_SPEED_* for link speed on LAN/WAN INAGAKI Hiroshi
2024-03-22 14:54 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240321135502.GA1637678-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hauke@hauke-m.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=musashino.open@gmail.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).