Linux LED subsystem development
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
	Kate Hsuan <hpa@redhat.com>,
	linux-leds@vger.kernel.org
Subject: Re: [RFC 0/2] leds: Add led_mc_set_brightness() and led_mc_trigger_event() functions
Date: Thu, 21 Mar 2024 18:18:49 +0000	[thread overview]
Message-ID: <20240321181849.GI13211@google.com> (raw)
In-Reply-To: <20240309190835.173703-1-hdegoede@redhat.com>

On Sat, 09 Mar 2024, Hans de Goede wrote:

> Hi All,
> 
> Here is a patch-series adding led_mc_set_brightness() and
> led_mc_trigger_event() functions for changing multi-color LED colors
> from inside the kernel.
> 
> This is a preparation series for adding a new trigger to
> drivers/power/supply/power_supply_leds.c which changes the color
> of a RGB LED depending on if the battery is discharging (LED off)
> charging (LED red) or full (LED green)
> 
> This is marked as RFC since the power_supply_leds.c changes have not
> been written yet and as such this is compile-tested only atm.
> The main goal of this RFC is to gather review feedback on the
> chosen approach in these 2 patches.
> 
> Regards,
> 
> Hans
> 
> 
> Hans de Goede (2):
>   leds: core: Add led_mc_set_brightness() function
>   leds: trigger: Add led_mc_trigger_event() function
> 
>  drivers/leds/led-class-multicolor.c |  1 +
>  drivers/leds/led-core.c             | 31 +++++++++++++++++++++++++++++
>  drivers/leds/led-triggers.c         | 20 +++++++++++++++++++
>  include/linux/leds.h                | 26 ++++++++++++++++++++++++
>  4 files changed, 78 insertions(+)

What is it you want me to do with this RFC patches Hans?

-- 
Lee Jones [李琼斯]

  parent reply	other threads:[~2024-03-21 18:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-09 19:08 [RFC 0/2] leds: Add led_mc_set_brightness() and led_mc_trigger_event() functions Hans de Goede
2024-03-09 19:08 ` [RFC 1/2] leds: core: Add led_mc_set_brightness() function Hans de Goede
2024-03-09 19:08 ` [RFC 2/2] leds: trigger: Add led_mc_trigger_event() function Hans de Goede
2024-03-18 21:05 ` [RFC 0/2] leds: Add led_mc_set_brightness() and led_mc_trigger_event() functions Jacek Anaszewski
2024-03-21 18:18 ` Lee Jones [this message]
2024-03-22  3:43   ` Kate Hsuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240321181849.GI13211@google.com \
    --to=lee@kernel.org \
    --cc=dmurphy@ti.com \
    --cc=hdegoede@redhat.com \
    --cc=hpa@redhat.com \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox