From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A6232772A; Wed, 12 Jun 2024 07:55:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718178919; cv=none; b=FDPDxY35sX57yNZMO0qcI+21rxpXcNt2CgoET3wRcqfyIYKCt35Kp2iWXjqmN3WXRt/rblC1eGnE0EbkvJOYvj7eJTSQghz5uPzQ1vREpbzjjaIJqz4HHRuWUAYFPc+Spo7ZS77bbW65txxPLd0eRZlonnxrnA7pmYF3kFd4S5w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718178919; c=relaxed/simple; bh=kA+gK3R1K0N3WlcTK15m+Is6Wd1GEeoj6lkFDDgAOGY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MJLUe6ePNkR0x578hom+x7G2Y8p2V5UIui2KuqXmiRsiTz8fIXg+Nu/vN6pEDY7BwKVaUZfM/vmYe3q/u+PImTBVZa5AM7YacN7VmpyQaC7QvtAfJ8wwZvRVa7MQKPes4SevNMlgC3/FWQmQ15G1tcHBoMU1Mba+7AmTirq7lTE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=W82+Lsoi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="W82+Lsoi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80B61C3277B; Wed, 12 Jun 2024 07:55:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1718178919; bh=kA+gK3R1K0N3WlcTK15m+Is6Wd1GEeoj6lkFDDgAOGY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W82+Lsoifld1Xd0wRHjr777X5Id5PyHMOGCc1qjZuHKvHM/rGphrmsPqp37Ngyy6s KYWxRjuX+xeBl5O7BXUBfCnTzs0gJkGgO6d0k5bpgdk/sra8DB1OL/MSnKZLVp8tZs VYJKDLywhQdEr+1Y0DX9Bc3mdhMGwpBXbwEhgz04= Date: Wed, 12 Jun 2024 09:55:16 +0200 From: Greg KH To: Markus Elfring Cc: Javier Carrasco , linux-leds@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Angelo Gioacchino Del Regno , Lee Jones , Matthias Brugger , Pavel Machek , stable@vger.kernel.org, LKML , Jonathan Cameron Subject: Re: [PATCH] leds: mt6360: fix memory leak in mt6360_init_isnk_properties() Message-ID: <2024061209-giddily-slander-a6db@gregkh> References: <20240611-leds-mt6360-memleak-v1-1-93642eb5011e@gmail.com> <010b1c91-fbde-4b01-a92e-8c14751c7699@web.de> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <010b1c91-fbde-4b01-a92e-8c14751c7699@web.de> On Tue, Jun 11, 2024 at 04:01:49PM +0200, Markus Elfring wrote: > … > > Add the missing calls to fwnode_handle_put(child) to avoid memory leaks > > in the error paths. > > I suggest to apply a goto chain for a while. > https://wiki.sei.cmu.edu/confluence/display/c/MEM12-C.+Consider+using+a+goto+chain+when+leaving+a+function+on+error+when+using+and+releasing+resources > > Will the application of scope-based resource management become feasible with another delay? > https://elixir.bootlin.com/linux/v6.10-rc3/source/include/linux/cleanup.h#L8 > > Regards, > Markus > Hi, This is the semi-friendly patch-bot of Greg Kroah-Hartman. Markus, you seem to have sent a nonsensical or otherwise pointless review comment to a patch submission on a Linux kernel developer mailing list. I strongly suggest that you not do this anymore. Please do not bother developers who are actively working to produce patches and features with comments that, in the end, are a waste of time. Patch submitter, please ignore Markus's suggestion; you do not need to follow it at all. The person/bot/AI that sent it is being ignored by almost all Linux kernel maintainers for having a persistent pattern of behavior of producing distracting and pointless commentary, and inability to adapt to feedback. Please feel free to also ignore emails from them. thanks, greg k-h's patch email bot